Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] Update lerna to 5.2.0 #33635

Merged
merged 1 commit into from
Jul 27, 2022
Merged

[core] Update lerna to 5.2.0 #33635

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion lerna.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
{
"npmClient": "yarn",
"useWorkspaces": true,
"version": "independent"
"version": "independent",
"useNx": true
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@michaldudak Curious how it worked out - are there any benefits of using nx?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't noticed any improvements in build times, but we now get a nicer preview of what's being built/checked when running locally.

Copy link
Member

@oliviertassinari oliviertassinari Aug 12, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at https://nx.dev/migration/lerna-and-nx#speed-up-lerna-with-nx's-powerful-task-scheduler, we are already running all the tasks in parallel, a smarter scheduler has no room for optimizations.

For the cache, maybe it's a bug? I mean if we don't publish @mui/styles, why build it? But then, maybe we don't care, it takes ~60s, once a week, and no cache might help, it avoid nasty bugs of implicit dependencies.

}
3 changes: 2 additions & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,11 +151,12 @@
"karma-mocha": "^2.0.1",
"karma-sourcemap-loader": "^0.3.8",
"karma-webpack": "^5.0.0",
"lerna": "^4.0.0",
"lerna": "^5.2.0",
"lodash": "^4.17.21",
"markdownlint-cli": "^0.32.1",
"mocha": "^10.0.0",
"node-fetch": "^2.6.7",
"nx": "^14.4.3",
"nyc": "^15.1.0",
"piscina": "^3.2.0",
"playwright": "^1.24.0",
Expand Down
Loading