-
-
Notifications
You must be signed in to change notification settings - Fork 32.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Autocomplete] Fixed autocomplete's existing option selection #36659
[Autocomplete] Fixed autocomplete's existing option selection #36659
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
when i typed god
in the autocomplete you provided in your sandbox, i can still see goodfellas
is highlighted. ideally The god father
should be highlighted
Hey @sai6855, I checked your comment on the issue, and based on the comment this is the correct behavior. If This change fixes the bug where hitting enter does not select the highlighted option. |
Okay but isn't this issue raised because first option isn't highlighted.
This part seems out of context with the issue you attached, can you create a new issue that this PR fixes and then attach the issue to this PR. Regarding my comment - it's incorrect, you can refer this comment for correct explanation #36336 (comment) |
OK, thank you for the clarification. I will change this fix because if the highlight restoration logic will be correct, this fix will be unnecessary :) |
Can you fix CI errors and make it green |
I don't know why it's red. I haven't done anything with CircleCI and can't find anything related in the docs. |
can you try creating new PR? |
Of course, I'm on it. |
The new pull request is #37012 |
Fixes #36336
CodeSandbox: https://codesandbox.io/s/mui-autocomplete-bug-fix-forked-033f61