Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Autocomplete] Fixed autocomplete's existing option selection #36659

Conversation

bencevoros
Copy link
Contributor

@bencevoros bencevoros commented Mar 27, 2023

Copy link
Contributor

@sai6855 sai6855 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

when i typed god in the autocomplete you provided in your sandbox, i can still see goodfellas is highlighted. ideally The god father should be highlighted

@bencevoros
Copy link
Contributor Author

Hey @sai6855, I checked your comment on the issue, and based on the comment this is the correct behavior. If Goodfellas still exists in the options, then it will be highlighted.

This change fixes the bug where hitting enter does not select the highlighted option.

@sai6855
Copy link
Contributor

sai6855 commented Mar 28, 2023

Hey @sai6855, I checked your comment on the issue, and based on the comment this is the correct behavior. If Goodfellas still exists in the options, then it will be highlighted.

This change fixes the bug where hitting enter does not select the highlighted option.

Okay but isn't this issue raised because first option isn't highlighted.

This change fixes the bug where hitting enter does not select the highlighted option

This part seems out of context with the issue you attached, can you create a new issue that this PR fixes and then attach the issue to this PR.

Regarding my comment - it's incorrect, you can refer this comment for correct explanation #36336 (comment)

@bencevoros
Copy link
Contributor Author

OK, thank you for the clarification. I will change this fix because if the highlight restoration logic will be correct, this fix will be unnecessary :)

@zannager zannager added the component: autocomplete This is the name of the generic UI component, not the React module! label Mar 28, 2023
@bencevoros bencevoros requested a review from sai6855 March 28, 2023 16:24
@sai6855
Copy link
Contributor

sai6855 commented Mar 28, 2023

Can you fix CI errors and make it green

@bencevoros
Copy link
Contributor Author

I don't know why it's red. I haven't done anything with CircleCI and can't find anything related in the docs.
The only thing that I've found is this bug report with the same issue: https://discuss.circleci.com/t/could-not-find-a-usable-config-yml-you-may-have-revoked-the-circleci-oauth-app/46274/5

@sai6855
Copy link
Contributor

sai6855 commented Apr 11, 2023

can you try creating new PR?

@bencevoros
Copy link
Contributor Author

Of course, I'm on it.

@bencevoros
Copy link
Contributor Author

The new pull request is #37012

@bencevoros bencevoros closed this Apr 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: autocomplete This is the name of the generic UI component, not the React module!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Autocomplete] the first option is not highlighted for autoHighlight using filterOptions
3 participants