Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FormControl] Fix filled when value is set through inputProps #36741

Merged
merged 2 commits into from
Apr 18, 2023

Conversation

sai6855
Copy link
Contributor

@sai6855 sai6855 commented Apr 1, 2023

@sai6855 sai6855 added bug 🐛 Something doesn't work package: material-ui Specific to @mui/material component: FormControl The React component labels Apr 1, 2023
@mui-bot
Copy link

mui-bot commented Apr 1, 2023

Netlify deploy preview

https://deploy-preview-36741--material-ui.netlify.app/

Bundle size report

Details of bundle changes

Generated by 🚫 dangerJS against 48e6e57

@sai6855 sai6855 changed the title [Input] Fix filled when value is set through inputProps [FormControl] Fix filled when value is set through inputProps Apr 1, 2023
@sai6855 sai6855 marked this pull request as draft April 1, 2023 10:49
@sai6855 sai6855 marked this pull request as ready for review April 1, 2023 12:08
Copy link
Member

@mj12albert mj12albert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@sai6855
Copy link
Contributor Author

sai6855 commented Apr 18, 2023

@mj12albert thanks for review, BTW I don't have access to merge. So if you feel it's good to go, you can merge it or we can wait for 2nd review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something doesn't work component: FormControl The React component package: material-ui Specific to @mui/material
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FormControl] Inconsistent initial transition behaviour in ssr when value is passed through inputProps
3 participants