[docs] Specify "Material UI" (not "MUI") where appropriate throughout the docs #37066
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sam Sycamore <[email protected]>
danilo-leal
approved these changes
Apr 27, 2023
binh1298
pushed a commit
to binh1298/material-ui
that referenced
this pull request
May 17, 2023
… the docs (mui#37066) Signed-off-by: Sam Sycamore <[email protected]>
Comment on lines
186
to
194
| "scripts": { | ||
| - "start": "react-scripts start", | ||
| - "build": "react-scripts build", | ||
| - "test": "react-scripts test", | ||
| + "start": "react-app-rewired start", | ||
| - "build": "react-scripts build", | ||
| + "build": "react-app-rewired build", | ||
| - "test": "react-scripts test", | ||
| + "test": "react-app-rewired test", | ||
| "eject": "react-scripts eject" | ||
| } |
There was a problem hiding this comment.
I think this was correct before.
✅
"scripts": {
- "start": "react-scripts start",
- "build": "react-scripts build",
- "test": "react-scripts test",
+ "start": "react-app-rewired start",
+ "build": "react-app-rewired build",
+ "test": "react-app-rewired test",
"eject": "react-scripts eject"
}❌
"scripts": {
- "start": "react-scripts start",
+ "start": "react-app-rewired start",
- "build": "react-scripts build",
+ "build": "react-app-rewired build",
- "test": "react-scripts test",
+ "test": "react-app-rewired test",
"eject": "react-scripts eject"
}Fixed in #38747.
Why? This is to make it easier to 1. follow what changed 2. copy and paste the change. This is how git behaves by default, developer will be less disoriented.
There was a problem hiding this comment.
Weird, I don't remember touching these lines at all in this PR—not sure how they got changed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In an effort to address the ongoing confusion about MUI vs. Material UI, I've combed through the documentation and tried to replace all instances of
MUIwhere we're actually talking aboutMaterial UIspecifically. We need to make sure that users understand that MUI the company is responsible for Material UI the product.This is a big PR that touches a lot of files, so I tried to keep edits limited to just this one thing. Exceptions are where the original sentences were in need of grammar touch-ups. I ignored blog posts.
I think some pages here need to be rewritten completely—Support and FAQ, for example—but I'll save those for future PRs.