-
-
Notifications
You must be signed in to change notification settings - Fork 32.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs][base-ui] Add tokens to plain CSS theme stylesheet #40113
Conversation
Co-authored-by: Michał Dudak <[email protected]> Signed-off-by: Marija Najdova <[email protected]>
Netlify deploy previewhttps://deploy-preview-40113--material-ui.netlify.app/ Bundle size report |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we plan to add these configs to the settings panel long term?
I think we could aim to adding some settings, like |
Just adding @mui/design on the loop! I'd love to hear your thoughts about the components' visual 😄 👉 https://deploy-preview-40113--material-ui.netlify.app/experiments/base/components-gallery/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 added a few suggestions, the rest looks good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
The customization popup, is broken, the color switcher does not work anymore. I haven't look further, but wanted to raise that up. I can check it tomorrow if you need help Victor |
Hey @mnajdova actually it's pretty broken everywhere 😅 —don't worry, though, it looks like this because @danilo-leal is adding some tweaks to the tokens, and I reckon he's still doing it haha. Anyway, I really appreciate the help, but I think after his tweaks we can merge this and work towards the next step: defining how we'll make it available for users. |
The Select component has to be updated because of #39675, as right now, it doesn't have a visual indication for keyboard navigation. We need to add a visible border with |
Merging this one as I feel like it's in great shape! If we spot more improvement opportunities, we can always open iterative follow-up PRs 😬 In fact, an obvious one would be adding a dark mode toggle, but, as this might be available within the documentation, I'm assuming the toggle will be there. Anyhow, great work, y'all! |
Co-authored-by: mnajdova <[email protected]> Co-authored-by: Michał Dudak <[email protected]> Co-authored-by: Danilo Leal <[email protected]>
Part of: #40108
This PR is to add the theme tokens to the stylesheet and tweak the component's styling accordingly.
Preview: https://deploy-preview-40113--material-ui.netlify.app/experiments/base/components-gallery/