Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[material-ui][docs] Fix ESLint error in Stepper demo #42559

Merged
merged 2 commits into from
Jun 7, 2024

Conversation

aarongarciah
Copy link
Member

@aarongarciah aarongarciah commented Jun 7, 2024

Part of #42548

Fixing an error reported by eslint-plugin-react-compiler in a Stepper demo:

/material-ui/docs/data/material/components/steppers/HorizontalNonLinearStepper.js
  51:5  error  This mutates a variable that React considers immutable  react-compiler/react-compiler

/material-ui/docs/data/material/components/steppers/HorizontalNonLinearStepper.tsx
  53:5  error  This mutates a variable that React considers immutable  react-compiler/react-compiler

How to test

@aarongarciah aarongarciah added docs Improvements or additions to the documentation package: material-ui Specific to @mui/material labels Jun 7, 2024
@aarongarciah aarongarciah requested a review from brijeshb42 June 7, 2024 09:49
@aarongarciah aarongarciah changed the title [material-ui][docs] Fix React Compiler error [material-ui][docs] Fix React Compiler ESLint error Jun 7, 2024
@mui-bot
Copy link

mui-bot commented Jun 7, 2024

Netlify deploy preview

https://deploy-preview-42559--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against 84ecc70

@aarongarciah aarongarciah changed the title [material-ui][docs] Fix React Compiler ESLint error [material-ui][docs] Fix ESLint error in Stepper demo Jun 7, 2024
@aarongarciah aarongarciah enabled auto-merge (squash) June 7, 2024 12:17
@aarongarciah aarongarciah merged commit 5a9fc4d into mui:next Jun 7, 2024
18 checks passed
@aarongarciah aarongarciah deleted the fix-demo-react-compiler-error branch June 7, 2024 12:42
@oliviertassinari
Copy link
Member

Ah nice, this one indeed seemed like a bug.

joserodolfofreitas pushed a commit to joserodolfofreitas/material-ui that referenced this pull request Jul 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to the documentation package: material-ui Specific to @mui/material
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants