-
-
Notifications
You must be signed in to change notification settings - Fork 32.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[material-ui] Refine Blog template #42825
Conversation
@DiegoAndai could you help me with failing tests? After fixing it, I believe this is ready for review :)
|
Hey @oliviertassinari! This template no longer uses markdown, so Can we remove it from the benchmark test? Asking as you initially introduced the test (PR): diff --git a/benchmark/server/scenarios/docs.js b/benchmark/server/scenarios/docs.js
index 25fa13feb8..a26b6d85cf 100644
--- a/benchmark/server/scenarios/docs.js
+++ b/benchmark/server/scenarios/docs.js
@@ -5,7 +5,6 @@ import Benchmark from 'benchmark';
import * as React from 'react';
import * as ReactDOMServer from 'react-dom/server';
import { MarkdownElement } from '@mui/docs/MarkdownElement';
-import Markdown from 'docs/data/material/getting-started/templates/blog/Markdown';
import { createStore } from 'redux';
import { Provider } from 'react-redux';
@@ -28,9 +27,6 @@ const store = createStore((state) => state, {
});
suite
- .add('Markdown', () => {
- ReactDOMServer.renderToString(<Markdown>{markdown}</Markdown>);
- })
.add('MarkdownElement', () => {
ReactDOMServer.renderToString(
<Provider store={store}> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Just have some formatting nits 😊
docs/data/material/getting-started/templates/blog/components/AppAppBar.tsx
Outdated
Show resolved
Hide resolved
docs/data/material/getting-started/templates/blog/components/Footer.tsx
Outdated
Show resolved
Hide resolved
docs/data/material/getting-started/templates/blog/components/MainContent.tsx
Outdated
Show resolved
Hide resolved
docs/data/material/getting-started/templates/blog/components/ToggleColorMode.tsx
Outdated
Show resolved
Hide resolved
docs/data/material/getting-started/templates/blog/theme/customizations/menus.js
Show resolved
Hide resolved
@aarongarciah I forgot you were on PTO this week, so I'm merging this one to start working on unifying the themes and making it consistent. Feel free to add your feedback here or in an issue, and I'll address it in a future PR 👍 |
Great work @zanivan. I didn't review the PR in depth, but a couple of details caught my eye:
|
Part of #37555
Figma prototype
👉 https://deploy-preview-42825--material-ui.netlify.app/material-ui/getting-started/templates/blog/