Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Grid2] Remove item and zeroMinWidth classes from grid2Classes #44419

Merged
merged 2 commits into from
Nov 19, 2024

Conversation

sai6855
Copy link
Contributor

@sai6855 sai6855 commented Nov 15, 2024

item , zeroMinWidth prop were removed from Grid2, but those are still present in grid2Classes object. This PR removes those instances

FYI: Grid2 is missing classes tab;le in API docs, i'm working on it,, will open seperate PR for it

docs for same https://mui.com/material-ui/migration/migration-grid-v2/#remove-props

@sai6855 sai6855 changed the title [material-ui][Grid2] Remove item and zeroMinWidth classes [material-ui][Grid2] Remove item and zeroMinWidth classes from grid2Classes Nov 15, 2024
@sai6855 sai6855 added bug 🐛 Something doesn't work component: Grid The React component. package: material-ui Specific to @mui/material labels Nov 15, 2024
@sai6855 sai6855 marked this pull request as draft November 15, 2024 10:44
@mui-bot
Copy link

mui-bot commented Nov 15, 2024

Netlify deploy preview

https://deploy-preview-44419--material-ui.netlify.app/

Bundle size report

Details of bundle changes (Toolpad)
Details of bundle changes

Generated by 🚫 dangerJS against d978ce2

@sai6855 sai6855 requested a review from siriwatknp November 15, 2024 12:07
@sai6855 sai6855 marked this pull request as ready for review November 15, 2024 12:08
@oliviertassinari oliviertassinari changed the title [material-ui][Grid2] Remove item and zeroMinWidth classes from grid2Classes [Grid2] Remove item and zeroMinWidth classes from grid2Classes Nov 15, 2024
@oliviertassinari oliviertassinari removed the package: material-ui Specific to @mui/material label Nov 15, 2024
@sai6855 sai6855 merged commit 6f04511 into mui:master Nov 19, 2024
20 checks passed
@sai6855 sai6855 deleted the grid-2-classes branch November 19, 2024 08:00
mnajdova pushed a commit to mnajdova/material-ui that referenced this pull request Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something doesn't work component: Grid The React component.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants