[Button] Fix CircularProgress import
#44473
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
siriwatknp
added
component: button
Netlify deploy previewBundle size reportDetails of bundle changes (Toolpad) |
aarongarciah
added
the
component: icon button
oliviertassinari
changed the title
CircularProgress importCircularProgress import
mnajdova
approved these changes
Nov 19, 2024
|
What if we were to have this in the eslint config? #42987 (comment). Effectively, it seems that we have good reason to do https://github.com/mui/mui-x/blob/340acbde76bbad3d7925f3c374cb9f23a8d7f924/.eslintrc.js#L57 now (MUI X is head here). |
siriwatknp
added a commit
to siriwatknp/material-ui
that referenced
this pull request
Nov 20, 2024
This reverts commit 0aecafc.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proptypes are updated based on comments in #42987 (comment)