Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[core] Setup React 18 CI tests #44868

Merged
merged 3 commits into from
Jan 3, 2025
Merged

[core] Setup React 18 CI tests #44868

merged 3 commits into from
Jan 3, 2025

Conversation

DiegoAndai
Copy link
Member

Closes: #44793

@DiegoAndai DiegoAndai added test core Infrastructure work going on behind the scenes labels Dec 27, 2024
@DiegoAndai DiegoAndai self-assigned this Dec 27, 2024
@mui-bot
Copy link

mui-bot commented Dec 27, 2024 •
edited
Loading

Netlify deploy preview

https://deploy-preview-44868--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against b63ff1b

@DiegoAndai DiegoAndai marked this pull request as ready for review December 27, 2024 17:49
@DiegoAndai
Copy link
Member Author

DiegoAndai commented Dec 27, 2024 •
edited
Loading

Manually ran React 18 tests: https://app.circleci.com/pipelines/github/mui/material-ui/145385/workflows/0f9c8f1e-3524-4d12-9dab-cd4eb6e3bcb6

aarongarciah
aarongarciah approved these changes Jan 3, 2025
View reviewed changes
Copy link
Member

@aarongarciah aarongarciah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅

@DiegoAndai DiegoAndai merged commit 5fe5dda into mui:master Jan 3, 2025
23 checks passed
@DiegoAndai DiegoAndai deleted the setup-react-18-testing branch January 3, 2025 12:34
@LukasTy
Copy link
Member

LukasTy commented Jan 3, 2025

For reference - on mui-x, we have currently set it up to run on push to main branches (v.x, master, next) to facilitate faster feedback in case of an issue.

This was referenced Jan 3, 2025
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aarongarciah aarongarciah aarongarciah approved these changes

Assignees

@DiegoAndai DiegoAndai

Labels
core Infrastructure work going on behind the scenes test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[core] Periodically run tests against React 18
4 participants
@DiegoAndai @mui-bot @LukasTy @aarongarciah