[material-ui][Select] Do not set aria-controls when closed
#44919
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Netlify deploy previewhttps://deploy-preview-44919--material-ui.netlify.app/ Bundle size reportDetails of bundle changes (Toolpad) |
zannager
added
the
component: select
|
@mj12albert can you please review the PR? |
mj12albert
requested changes
Jan 6, 2025
Co-authored-by: Albert Yu <[email protected]> Signed-off-by: siddhantantil39 <[email protected]>
mj12albert
reviewed
Jan 6, 2025
mj12albert
reviewed
Jan 6, 2025
Co-authored-by: Albert Yu <[email protected]> Signed-off-by: siddhantantil39 <[email protected]>
Co-authored-by: Albert Yu <[email protected]> Signed-off-by: siddhantantil39 <[email protected]>
|
I've added the suggestions added by @mj12albert . Feel free to have a look whenever possible. |
mj12albert
changed the title
aria-controls when closed
mj12albert
approved these changes
Jan 7, 2025
Looks good! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have added a check to set the aria-controls to check if select is open or not before setting the value as listboxId