Review: Olivier

mui · Aug 14, 2024 · 0e3e43b · 0e3e43b
1 parent e1cccca
commit 0e3e43b
Show file tree

Hide file tree

Showing 6 changed files with 5 additions and 6 deletions.
diff --git a/docs/translations/api-docs/tree-view/rich-tree-view-pro/rich-tree-view-pro.json b/docs/translations/api-docs/tree-view/rich-tree-view-pro/rich-tree-view-pro.json
@@ -138,7 +138,7 @@
     "resizeThrottleMs": {
       "description": "The millisecond throttle delay for resizing the Tree View when virtualization is enabled."
     },
-    "scrollBufferPx": { "description": "Region in pixels to render before/after the viewport" },
+    "scrollBufferPx": { "description": "Region in pixels to render before/after the viewport." },
     "selectedItems": {
       "description": "Selected item ids. (Controlled) When <code>multiSelect</code> is true this takes an array of strings; when false (default) a string."
     },

diff --git a/packages/x-tree-view-pro/src/RichTreeViewPro/RichTreeViewPro.tsx b/packages/x-tree-view-pro/src/RichTreeViewPro/RichTreeViewPro.tsx
@@ -332,7 +332,7 @@ RichTreeViewPro.propTypes = {
    */
   resizeThrottleMs: PropTypes.number,
   /**
-   * Region in pixels to render before/after the viewport
+   * Region in pixels to render before/after the viewport.
    * @default 150
    */
   scrollBufferPx: PropTypes.number,

diff --git a/packages/x-tree-view-pro/src/TreeViewVirtualScroller/TreeViewVirtualScrollbar.tsx b/packages/x-tree-view-pro/src/TreeViewVirtualScroller/TreeViewVirtualScrollbar.tsx
@@ -46,7 +46,7 @@ export const TreeViewVirtualScrollbar = React.forwardRef<
   } = useTreeViewContext<[UseTreeViewVirtualizationSignature]>();
   const isLocked = React.useRef(false);
   const lastPosition = React.useRef(0);
-  const scrollbarRef = React.useRef<HTMLDivElement>(null);
+  const scrollbarRef = React.useRef<HTMLDivElement | null>(null);
   const contentRef = React.useRef<HTMLDivElement>(null);
 
   const dimensions = instance.getDimensions();

diff --git a/packages/x-tree-view-pro/src/TreeViewVirtualScroller/TreeViewVirtualScroller.tsx b/packages/x-tree-view-pro/src/TreeViewVirtualScroller/TreeViewVirtualScroller.tsx
@@ -16,7 +16,6 @@ const TreeViewVirtualScrollerRoot = styled('div', {
   '--TreeView-scrollbarSize': '10px',
   '--TreeView-hasScrollX': '0',
   '--TreeView-hasScrollY': '0',
-
   flexGrow: 1,
   position: 'relative',
   overflow: 'hidden',

diff --git a/...ree-view-pro/src/internals/plugins/useTreeViewVirtualization/useTreeViewVirtualization.ts b/...ree-view-pro/src/internals/plugins/useTreeViewVirtualization/useTreeViewVirtualization.ts
@@ -81,7 +81,7 @@ export const useTreeViewVirtualization: TreeViewPlugin<UseTreeViewVirtualization
       if (process.env.NODE_ENV !== 'production') {
         if (newSize.height === 0 && !isJSDOM) {
           warnOnce([
-            'The parent DOM element of the tree view has an empty height.',
+            'MUI X: The parent DOM element of the tree view has an empty height.',
             'Please make sure that this element has an intrinsic height.',
             'The tree view displays with a height of 0px.',
             '',

diff --git a/...ew-pro/src/internals/plugins/useTreeViewVirtualization/useTreeViewVirtualization.types.ts b/...ew-pro/src/internals/plugins/useTreeViewVirtualization/useTreeViewVirtualization.types.ts
@@ -22,7 +22,7 @@ export interface UseTreeViewVirtualizationInstance {
 
 export interface UseTreeViewVirtualizationParameters {
   /**
-   * Region in pixels to render before/after the viewport
+   * Region in pixels to render before/after the viewport.
    * @default 150
    */
   scrollBufferPx?: number;