Code review: Michel

mui · Feb 28, 2024 · 5d01f83 · 5d01f83
1 parent 16dcad0
commit 5d01f83
Show file tree

Hide file tree

Showing 5 changed files with 9 additions and 12 deletions.
diff --git a/test/utils/pickers/describeRangeValidation/testDayViewRangeValidation.tsx b/test/utils/pickers/describeRangeValidation/testDayViewRangeValidation.tsx
@@ -3,10 +3,10 @@ import { expect } from 'chai';
 import { screen } from '@mui-internal/test-utils';
 import { adapterToUse } from 'test/utils/pickers';
 
-const isDisable = (el: HTMLElement) => el.getAttribute('disabled') !== null;
+const isDisabled = (el: HTMLElement) => el.getAttribute('disabled') !== null;
 
 const testDisabledDate = (day: string, expectedAnswer: boolean[], isSingleCalendar: boolean) => {
-  expect(screen.getAllByRole('gridcell', { name: day }).map(isDisable)).to.deep.equal(
+  expect(screen.getAllByRole('gridcell', { name: day }).map(isDisabled)).to.deep.equal(
     isSingleCalendar ? expectedAnswer.slice(0, 1) : expectedAnswer,
   );
 };

diff --git a/test/utils/pickers/describeValue/testControlledUnControlled.tsx b/test/utils/pickers/describeValue/testControlledUnControlled.tsx
@@ -28,7 +28,7 @@ export const testControlledUnControlled: DescribeValueTestSuite<any, any> = (
 
   const params = pickerParams as DescribeValueOptions<'picker', any>;
 
-  const isRangeType = ['date-range', 'date-time-range'].includes(params.type);
+  const isRangeType = params.type === 'date-range' || params.type === 'date-time-range';
   const isDesktopRange = params.variant === 'desktop' && isRangeType;
 
   describe('Controlled / uncontrolled value', () => {
@@ -257,10 +257,7 @@ export const testControlledUnControlled: DescribeValueTestSuite<any, any> = (
         expect(fieldRoot).to.have.class(inputBaseClasses.error);
         expect(fieldRoot).to.have.attribute('aria-invalid', 'true');
 
-        if (
-          (params.type === 'date-range' || params.type === 'date-time-range') &&
-          !params.isSingleInput
-        ) {
+        if (isRangeType && !params.isSingleInput) {
           const fieldRootEnd = getFieldInputRoot(1);
           expect(fieldRootEnd).to.have.class(inputBaseClasses.error);
           expect(fieldRootEnd).to.have.attribute('aria-invalid', 'true');

diff --git a/test/utils/pickers/describeValue/testPickerActionBar.tsx b/test/utils/pickers/describeValue/testPickerActionBar.tsx
@@ -27,7 +27,7 @@ export const testPickerActionBar: DescribeValueTestSuite<any, 'picker'> = (
     return;
   }
 
-  const isRangeType = ['date-range', 'date-time-range'].includes(pickerParams.type);
+  const isRangeType = pickerParams.type === 'date-range' || pickerParams.type === 'date-time-range';
 
   describe('Picker action bar', () => {
     describe('clear action', () => {

diff --git a/test/utils/pickers/describeValue/testPickerOpenCloseLifeCycle.tsx b/test/utils/pickers/describeValue/testPickerOpenCloseLifeCycle.tsx
@@ -16,7 +16,7 @@ export const testPickerOpenCloseLifeCycle: DescribeValueTestSuite<any, 'picker'>
     return;
   }
 
-  const isRangeType = ['date-range', 'date-time-range'].includes(pickerParams.type);
+  const isRangeType = pickerParams.type === 'date-range' || pickerParams.type === 'date-time-range';
   const viewWrapperRole = isRangeType && pickerParams.variant === 'desktop' ? 'tooltip' : 'dialog';
 
   describe('Picker open / close lifecycle', () => {

diff --git a/test/utils/pickers/openPicker.ts b/test/utils/pickers/openPicker.ts
@@ -18,12 +18,12 @@ export type OpenPickerParams =
     };
 
 export const openPicker = (params: OpenPickerParams) => {
-  const isRangePicker = params.type === 'date-range' || params.type === 'date-time-range';
+  const isRangeType = params.type === 'date-range' || params.type === 'date-time-range';
   const fieldSectionsContainer = getFieldSectionsContainer(
-    isRangePicker && !params.isSingleInput && params.initialFocus === 'end' ? 1 : 0,
+    isRangeType && !params.isSingleInput && params.initialFocus === 'end' ? 1 : 0,
   );
 
-  if (isRangePicker) {
+  if (isRangeType) {
     userEvent.mousePress(fieldSectionsContainer);
 
     if (params.isSingleInput && params.initialFocus === 'end') {