-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[datagrid] Autosize Columns - Headers being cut off #10570
Comments
I was able to reproduce it but for me, the first column is the one that breaks. |
Mobile has always-visible 3-dots menus. We'll need to add space to the headers to account for that. |
@DevPowers @zannager @DanailH we would like to pick this up |
@gitstart ok, we are happy for you to try it out, but because this bug is related to a Premium feature we would need you to sign a CLA before we are able to merge it. Once you open the PR we can send you the standard agreement. |
Thanks for the response @DanailH, we are fine with signing the CLA agreement. |
Please do also consider sorted columns: extra space for the sort direction arrow icon has to be added. |
@gitstart Are you able to get eyes on the PR again ?? This is a priority fix I need for this feature to be production ready 🙏 |
@DevPowers We are sorry for the delay 🙏. The PR has been updated. |
Is anybody able to pick this up? I see numerous other bugs opened against this new autosize feature, is it possible to make this a priority on fixing all the autosize bugs in upcoming v7 release? |
Autosizing has been reworked in the v7 branch, it seems to work fine there: https://next.mui.com/x/react-data-grid/column-dimensions Is it possible for you to use v7? |
@romgrk Hi! Testing autosize for mobile with the page URL you sent looks to be working. I will close this ticket then, I can switch to V7 thanks! |
How did we do @DevPowers? |
@romgrk Hi, I just completed V7 migration. Unfortunately autosize is still buggy.
I can't say why it looks to work in the docs, vs in real life. When testing, I was using the button which may have something to do with it. |
Let's test again once #12013 is merged. |
How did we do @DevPowers? |
We've fixed some issues with autosizing. Could you confirm which issues are still reproducible for you? Next branch: https://next.mui.com/x/react-data-grid |
@romgrk Retested and still completely broken on mobile and desktop. Same issues: [Laptop view] - Pinned column on the left does not autosize and fit the column data |
Can you provide a clear reproduction case? I have tried modifying the docs example you link above to pin left one of the columns, and add the autosize options you list. The video below shows the result I observe. I get the same results in mobile emulation mode, let me know if you tested on a real mobile device. You also haven't filled the environment section in your report. It's important because it also tells us which OS and browser versions you're using, which are important to reproduce a bug. Kooha-2024-03-05-15-06-38.webm |
The issue has been inactive for 7 days and has been automatically closed. |
Steps to reproduce
Link to live example: (MUI Docs Example)
Steps:
Current behavior
The column headers are unreadable on mobile using autosizing
Expected behavior
For the column headers to be readable
Context
No response
Your environment
npx @mui/envinfo
Search keywords: datagrid column autosizing
Order ID: 56883
The text was updated successfully, but these errors were encountered: