[DataGridPro] Autosize Columns - Headers being cut off #10666
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…or columns Co-authored-by: seunexplicit <[email protected]>
|
Deploy preview: https://deploy-preview-10666--material-ui-x.netlify.app/ |
romgrk
changed the title
romgrk
reviewed
Oct 13, 2023
Comment on lines
+233
to
+244
| const iconContainer = header.querySelector(`.${gridClasses.iconButtonContainer}`); | ||
| const menuContainer = header.querySelector(`.${gridClasses.menuIcon}`); | ||
| const element = title ?? content; | ||
|
|
||
| const style = window.getComputedStyle(header, null); | ||
| const paddingWidth = parseInt(style.paddingLeft, 10) + parseInt(style.paddingRight, 10); | ||
| const contentWidth = element.scrollWidth + 1; | ||
| const width = paddingWidth + contentWidth; | ||
| const width = | ||
| contentWidth + | ||
| paddingWidth + | ||
| (iconContainer?.clientWidth ?? 0) + | ||
| (menuContainer?.clientWidth ?? 0); |
There was a problem hiding this comment.
I think we'll have to differentiate the logic for desktop & mobile. We only keep the icons visible at all times on mobile, and we don't want to pay the width cost on desktop.
There was a problem hiding this comment.
@romgrk Apologies for the delay in resolving this.
The logic actually takes that into account already. Here is a loom video to confirm
zannager
added
the
component: data grid
Co-authored-by: seunexplicit <[email protected]>
romgrk
approved these changes
Nov 7, 2023
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Screenshot
closes #10570
This code was written and reviewed by GitStart Community. Growing great engineers, one PR at a time.