Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[pickers] Fix styling props propagation to DateTimePickerTabs #12096

Merged
merged 10 commits into from
Feb 19, 2024
Merged

[pickers] Fix styling props propagation to DateTimePickerTabs #12096

merged 10 commits into from
Feb 19, 2024

Conversation

LukasTy
Copy link
Member

@LukasTy LukasTy commented Feb 16, 2024 •
edited
Loading

Fixes #11532

  • Propagate sx prop to DateTimeRangePickerTabs
  • Expose the classes prop on DateTimePickerToolbar
  • Fix className and classes behavior on DatePickerToolbar
  • Fix className and classes behavior on TimePickerToolbar
  • Add missing classes prop JSDoc
  • Add missing sx prop JSDoc on Tabs, Toolbars, and PickersLayout components

@LukasTy LukasTy added bug 🐛 Something doesn't work component: pickers This is the name of the generic UI component, not the React module! customization: css Design CSS customizability enhancement This is not a bug, nor a new feature labels Feb 16, 2024
@LukasTy LukasTy self-assigned this Feb 16, 2024
@mui-bot
Copy link

mui-bot commented Feb 16, 2024 •
edited
Loading

Deploy preview: https://deploy-preview-12096--material-ui-x.netlify.app/

Generated by 🚫 dangerJS against 2061a2b

@LukasTy LukasTy added the needs cherry-pick The PR should be cherry-picked to master after merge label Feb 16, 2024
@LukasTy LukasTy merged commit dcf4126 into mui:next Feb 19, 2024
18 checks passed
@LukasTy LukasTy deleted the fix-tabs-styling branch February 19, 2024 09:01
LukasTy added a commit to LukasTy/mui-x that referenced this pull request Feb 19, 2024
@LukasTy
[pickers] Fix styling props propagation to DateTimePickerTabs (mui#…
b091c7e 
…12096)
@LukasTy LukasTy mentioned this pull request Feb 19, 2024
Merged
thomasmoon pushed a commit to thomasmoon/mui-x that referenced this pull request Sep 9, 2024
@LukasTy @thomasmoon
[pickers] Fix styling props propagation to DateTimePickerTabs (mui#…
9994b6d 
…12096)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flaviendelangle flaviendelangle flaviendelangle approved these changes

@michelengelen michelengelen Awaiting requested review from michelengelen

Assignees

@LukasTy LukasTy

Labels
bug 🐛 Something doesn't work component: pickers This is the name of the generic UI component, not the React module! customization: css Design CSS customizability enhancement This is not a bug, nor a new feature needs cherry-pick The PR should be cherry-picked to master after merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[DateTimePicker] Can't change the color for the tabs
3 participants
@LukasTy @mui-bot @flaviendelangle