[DataGrid] Remove GridFormatterParams completely #12660
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romgrk
added
the
component: data grid
|
Deploy preview: https://deploy-preview-12660--material-ui-x.netlify.app/ |
MBilalShafi
approved these changes
Apr 4, 2024
| @@ -641,7 +641,7 @@ describe('<DataGridPremium /> - Aggregation', () => { | |||
| it('should use the aggregation function valueFormatter if defined', () => { | |||
| const customAggregationFunction: GridAggregationFunction = { | |||
| apply: () => 'Agg value', | |||
| valueFormatter: (params) => `+ ${params.value}`, | |||
| valueFormatter: (value) => `+ ${value}`, | |||
There was a problem hiding this comment.
Probably document this in the migration guide and release notes
There was a problem hiding this comment.
It's already in. This was missed during the refactor.
There was a problem hiding this comment.
The failing argos SS could be fixed by:
diff --git a/docs/data/data-grid/aggregation/AggregationValueFormatter.tsx b/docs/data/data-grid/aggregation/AggregationValueFormatter.tsx
index 1a3f4c5a1..e5be77639 100644
--- a/docs/data/data-grid/aggregation/AggregationValueFormatter.tsx
+++ b/docs/data/data-grid/aggregation/AggregationValueFormatter.tsx
@@ -48,7 +48,7 @@ const firstAlphabeticalAggregation: GridAggregationFunction<string, string | nul
return sortedValue[0];
},
label: 'first alphabetical',
- valueFormatter: (params) => `Agg: ${params.value}`,
+ valueFormatter: (value) => `Agg: ${value}`,
columnTypes: ['string'],
};
|
Thanks! I overlooked this in #11573 |
DungTiger
pushed a commit
to DungTiger/mui-x
that referenced
this pull request
Jul 23, 2024
thomasmoon
pushed a commit
to thomasmoon/mui-x
that referenced
this pull request
Sep 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #12658
We didn't complete this breaking change. This is now a bug at runtime for users, so we need to remove it even if we didn't do it at v7 release.