Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DataGridPro] Fix indeterminate checkbox state for server-side data #14956

Merged
merged 1 commit into from
Oct 16, 2024

Conversation

MBilalShafi
Copy link
Member

@MBilalShafi MBilalShafi commented Oct 14, 2024

@MBilalShafi MBilalShafi added bug 🐛 Something doesn't work component: data grid This is the name of the generic UI component, not the React module! feature: Selection Related to the data grid Selection feature labels Oct 14, 2024
@MBilalShafi MBilalShafi changed the title [DataGridPro] Fix indeterminate checkbox state for server-side tree data [DataGridPro] Fix indeterminate checkbox state for server-side data Oct 14, 2024
@mui-bot
Copy link

mui-bot commented Oct 14, 2024

Deploy preview: https://deploy-preview-14956--material-ui-x.netlify.app/

Generated by 🚫 dangerJS against 7df0782

@MBilalShafi MBilalShafi requested a review from a team October 16, 2024 13:30
@MBilalShafi MBilalShafi marked this pull request as ready for review October 16, 2024 13:30
@arminmeh
Copy link
Contributor

would be good to add a test for this so that we don't get regression if we do some refactoring in the future

@MBilalShafi MBilalShafi merged commit aa40880 into mui:master Oct 16, 2024
24 checks passed
@MBilalShafi
Copy link
Member Author

MBilalShafi commented Oct 16, 2024

would be good to add a test for this so that we don't get regression if we do some refactoring in the future

This specific use-case was trivial enough in my opinion to add a test case for, however I'll try to add one in a follow up PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something doesn't work component: data grid This is the name of the generic UI component, not the React module! feature: Selection Related to the data grid Selection feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[data grid] Server tree data checkboxSelection style init
3 participants