Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core][DataGrid] Remove more material imports #15063

Merged
merged 1 commit into from
Oct 23, 2024

Conversation

romgrk
Copy link
Contributor

@romgrk romgrk commented Oct 23, 2024

Remove a few more imports.

@romgrk romgrk added the component: data grid This is the name of the generic UI component, not the React module! label Oct 23, 2024
@romgrk romgrk requested a review from a team October 23, 2024 04:13
@romgrk romgrk changed the title [DataGrid] refactor: small design-system agnostic changes [DataGrid] refactor: remove more material imports Oct 23, 2024
@mui-bot
Copy link

mui-bot commented Oct 23, 2024

Deploy preview: https://deploy-preview-15063--material-ui-x.netlify.app/

Generated by 🚫 dangerJS against e9ff936

@romgrk romgrk merged commit 10985e8 into mui:master Oct 23, 2024
20 checks passed
@romgrk romgrk deleted the refactor-agnostic-small-changes branch October 23, 2024 21:23
@oliviertassinari oliviertassinari added the core Infrastructure work going on behind the scenes label Oct 23, 2024
@oliviertassinari oliviertassinari changed the title [DataGrid] refactor: remove more material imports [core][DataGrid] Remove more material imports Oct 23, 2024
@oliviertassinari
Copy link
Member

oliviertassinari commented Oct 23, 2024

This direction is cool 👍. It's coherent with https://www.notion.so/mui-org/engineering-mui-utils-purpose-9a9fc9da3a004864b6c4e1f4d1f24f95 as it's about skipping reexports (nothing is Material UI specific on this one) and it's coherent with mui/material-ui#35840 about avoiding barrel index use like the plague.

Only to be mindful that @mui/utils, per the notion page linked is going away, so there will be another import change in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: data grid This is the name of the generic UI component, not the React module! core Infrastructure work going on behind the scenes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants