[DataGrid] Prevent error when deleting the last row #15146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Issue: Error When Deleting the Last Row Description: When the last row in the Data Grid is deleted, an error occurs: Cannot read properties of undefined (reading 'id'). This happens because the grid tries to focus on a row that no longer exists. Proposed Solution: To fix this, we changed the code to safely access the id of the next row using optional chaining. This ensures that if there are no rows left, it won't throw an error. Code Change: javascript Copy code const nextRow = currentPage.rows[clamp(lastFocusedRowIndex, 0, currentPage.rows.length - 1)]; nextRowId = nextRow?.id ?? null; // Safely access the id This modification prevents errors and improves the handling of row deletions in the Data Grid. Signed-off-by: Deepak Maurya <[email protected]>
1 task
|
Deploy preview: https://deploy-preview-15146--material-ui-x.netlify.app/ |
dpak-maurya
changed the title
alexfauquette
changed the title
alexfauquette
added
bug 🐛
KenanYusuf
approved these changes
Oct 28, 2024
KenanYusuf
pushed a commit
to KenanYusuf/mui-x
that referenced
this pull request
Oct 28, 2024
Signed-off-by: Deepak Maurya <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #15145
Issue: Error When Deleting the Last Row
Description: When the last row in the Data Grid is deleted, an error occurs: Cannot read properties of undefined (reading 'id'). This happens because the grid tries to focus on a row that no longer exists.
Proposed Solution:
To fix this, we changed the code to safely access the id of the next row using optional chaining. This ensures that if there are no rows left, it won't throw an error.
Code Change:
nextRowId = nextRow?.id ?? null; // Safely access the idThis modification prevents errors and improves the handling of row deletions in the Data Grid.