-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump React #15255
Merged
+324
−377
Merged
Bump React #15255
Changes from all commits
Commits
Show all changes
30 commits
Select commit
Hold shift + click to select a range
79a0cbf
Bump @types/react to ^18.3.5
renovate[bot] 2c71612
fix Cell and Row props types
cherniavskii a689d8a
fix type errors in test files
cherniavskii 46a0052
Merge remote-tracking branch 'mui/master' into renovate/react
cherniavskii 9ee51e7
update lockfile
cherniavskii 1c7a7d4
proptypes
cherniavskii 13acded
proptypes
cherniavskii 72d2eb7
lint
cherniavskii b162a8b
Extract `ExportMenuItem` components separately to have consistent `pr…
LukasTy e19eb7d
Fix usage and docs
LukasTy 2f94d98
Merge branch 'master' into renovate/react
cherniavskii 842561c
revert toolbar export type change
cherniavskii 174433d
use theme augmentation
cherniavskii 868a335
Merge remote-tracking branch 'upstream/master' into renovate/react
LukasTy 5daff1e
Bump to latest `@types/react` version
LukasTy 8b4fb9d
Possibly more correct children type
LukasTy 4865bf1
Revert exporting
LukasTy b3dabe1
Fix too loose type causing `proptypes` randomness
LukasTy b26a822
Revert to a single `GridToolbarExport` file with fixed types to avoid…
LukasTy 65e9d1f
Small tweaks
LukasTy 602cb3a
Bump `@types/react-dom`
LukasTy ad494f8
Fix eslint
LukasTy 43f59a3
Remove no longer needed as slot casting
LukasTy 50ae593
Fix module augmentation
LukasTy 88e7702
Merge remote-tracking branch 'upstream/master' into renovate/react
LukasTy f93c892
fix toolbar ts error
cherniavskii 0b1e3cc
proptypes
cherniavskii 00b586f
Merge branch 'master' into renovate/react
cherniavskii 5a1cd23
fix build
cherniavskii 6a86fe4
fix type export
cherniavskii File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 changes: 2 additions & 6 deletions
8
docs/data/data-grid/filtering/CustomFilterPanelPosition.tsx.preview
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,14 +1,10 @@ | ||
<DataGrid | ||
{...data} | ||
slots={{ | ||
toolbar: CustomToolbar as GridSlots['toolbar'], | ||
}} | ||
slots={{ toolbar: CustomToolbar }} | ||
slotProps={{ | ||
panel: { | ||
anchorEl: filterButtonEl, | ||
}, | ||
toolbar: { | ||
setFilterButtonEl, | ||
}, | ||
toolbar: { setFilterButtonEl }, | ||
}} | ||
/> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If
pro
andpremium
package module augmentation are mixed in a single project—it goes haywire. 🙈There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After some of this dogfooding—this is my main gripe with module augmentation. 🙈
If users extend the same types for different package versions—they come to experience unexpected behavior. 🤷