Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[charts] Remove intrinsic size requirement #15471
[charts] Remove intrinsic size requirement #15471
Changes from 13 commits
0d7a441
5c258c0
a0e960a
f620c87
9f62e38
b110fd0
13a6ce8
38e2229
c282408
6ff7a2d
cf12e27
aee3572
ac93bca
3cae24c
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That let me think that the initial idea of this early return was to skip providers on first render.
If you have no width/height, you will have default width/height used to compute scales, coordinate, ... And when it renders, the
width
/height
get their real size and everything run a second time. The idea was to skip the useless step.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Providers are now on top of this component, since the datasource is the
<ChartDataProvider>
now. So I moved the check to theChartsSurface
. This means we can render the<svg/>
TAG on the first render, but everything else is only rendered if we have an intrinsic size