[docs][data grid] Revise the Data Grid getting started docs #15757
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mapache-salvaje
commented
Jan 15, 2025
Signed-off-by: Sycamore <[email protected]>
mapache-salvaje
requested review from
KenanYusuf,
cherniavskii,
michelengelen and
alelthomas
mapache-salvaje
commented
Jan 15, 2025
|
|
||
| ```tsx | ||
| // Pro and Premium users: add `-pro` or `-premium` suffix to package name |
There was a problem hiding this comment.
I'm still on the fence about which is preferable:
- list all three imports? (annoying for copy+paste)
- only include Community version? (could be unclear or just a minor annoyance for paid users)
There was a problem hiding this comment.
Not for this PR, but I was wondering if we could improve the overall experience of the Data Grid docs by having a plan switcher. Something like this, but it would apply to all of the snippets (and maybe demos) to only show the package that the user is interested in:
Screen.Recording.2025-01-16.at.14.29.08.mov
There was a problem hiding this comment.
Yeah that would be nice to have!
mapache-salvaje
added
enhancement
michelengelen
approved these changes
Jan 16, 2025
alelthomas
reviewed
Jan 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP
Closes #15719
Thorough revision of the Data Grid Getting Started docs and a few other pages where content has been rearranged:
renderCell(),valueGetter(), andvalueFormatter()