[fields] Always use `props.value` as the source of truth when defined #15875

flaviendelangle · 2024-12-13T13:57:44Z

We should now have a behavior coherent with the browser input and working well on range inputs as well.
Not sure if we should count that purely as a bug fix or as a breaking change.

Follow up

Always use the props.value as the source of truth in usePickerValue (should be a lot simpler)

mui-bot · 2024-12-13T14:01:48Z

Deploy preview: https://deploy-preview-15875--material-ui-x.netlify.app/

Generated by 🚫 dangerJS against 245f6bf

…o value-field-source-of-truth

flaviendelangle · 2024-12-20T13:16:19Z

packages/x-date-pickers/src/DateField/tests/format.DateField.test.tsx

      // For Day.js: "[Escaped] YYYY"
      format: `${startChar}Escaped${endChar} ${adapter.formats.year}`,
-      enableAccessibleFieldDOMStructure: false,
+      value: null,


I fixed a lot of tests that were switching from uncontrolled to controlled.

flaviendelangle · 2024-12-20T13:17:03Z

packages/x-date-pickers/src/internals/hooks/useField/useField.types.ts

- * Object used to access and update the active date (i.e: the date containing the active section).
- * Mainly useful in the range fields where we need to update the date containing the active section without impacting the other one.
- */
-interface FieldActiveDateManager<TValue extends PickerValidValue> {


I'm removing this concept because we don't need to update the reference value in multiple places anymore.
Instead I aligned the needed methods inside the field value manager.

flaviendelangle · 2024-12-20T13:18:16Z

packages/x-date-pickers/src/internals/hooks/useField/useField.types.ts

+  /**
+   * Last value of the parameters used to generate the sections.
+   */
+  lastSectionsDependencies: { format: string; isRtl: boolean; locale: any };


I'm storing those in state instead of using an effect to avoid a double re-render.
It's not strictly related to this PR but since I moved to this approach for the value update, I feared mis-synchronization if one update was in the render and another was in an effect.

flaviendelangle · 2024-12-20T13:20:16Z

packages/x-date-pickers/src/internals/hooks/useField/useField.utils.ts

@@ -659,12 +659,15 @@ const transferDateSectionValue = (
    }

    case 'weekDay': {
+      let dayInWeekStrOfActiveDate = utils.formatByString(dateToTransferFrom, section.format);


This fixes a bug highlighted by the new behavior but already here before.
For the E format of Luxon, the day of the week does not have leading zeroes, so dayInWeekStrOfActiveDate was equal to let's say 4and formattedDaysInWeek was ['1', '2, ...].
Which means dayInWeekOfNewSectionValue was equal to -1 and that messed up with the editing.

Before the bug was only visible on the value passed to onChange.
Now it's also visible on the value rendered.

So this PR also improves how we actually test all the tokens 👌

flaviendelangle · 2024-12-20T13:22:30Z

packages/x-date-pickers/src/models/adapters.ts

@@ -191,8 +191,10 @@ export interface MuiPickersAdapter<TLocale = any> {
    value?: T,
    timezone?: PickersTimezone,
  ): DateBuilderReturnType<T>;
+  // TODO v9: Remove.


We don't need it anymore, but it does not cost much to keep it so I'm deprecating it for next major.

github-actions · 2024-12-30T09:19:07Z

This pull request has conflicts, please resolve those before we can evaluate the pull request.

github-actions · 2025-01-02T11:47:39Z

This pull request has conflicts, please resolve those before we can evaluate the pull request.

LukasTy · 2025-01-24T10:08:31Z

I've tested the behaviors and issues that were closed as duplicates in favor of the original issue, and it seems there are still some behaviors missing.
I've created a sandbox with the various behaviors: https://codesandbox.io/p/sandbox/jolly-forest-lqtsfy

LukasTy

Besides, correct me if I'm wrong, but it looks like this PR changes the value lifecycle.
We no longer have an intermediary Invalid date. 🙈
This is quite a massive BC. Is it necessary to solve the underlying issue? 🤔

flaviendelangle · 2025-01-24T13:28:49Z

We no longer have an intermediary Invalid date. 🙈

Indeed
Is it required? To have the same behavior as the browser input yes I think it is.
It all depends how similar to it we want to be. With the new approach I felt like it made sense.

flaviendelangle · 2025-01-24T13:54:05Z

I've created a sandbox with the various behaviors: https://codesandbox.io/p/sandbox/jolly-forest-lqtsfy

Your demos use DatePicker but this PR only focuses on DateField, I did not fix the control layer of the picker yet.
Did you reproduce those issues with the standalone fields?

LukasTy · 2025-01-27T14:16:31Z

I've created a sandbox with the various behaviors: https://codesandbox.io/p/sandbox/jolly-forest-lqtsfy

Your demos use DatePicker but this PR only focuses on DateField, I did not fix the control layer of the picker yet. Did you reproduce those issues with the standalone fields?

Indeed, sorry for missing that. 🙈
The same problems on DateField instead seem resolved. 👌 🎉

We no longer have an intermediary Invalid date. 🙈

Indeed Is it required? To have the same behavior as the browser input yes I think it is. It all depends how similar to it we want to be. With the new approach I felt like it made sense.

Maybe not required, but I feel like it's a separate topic. If it can be extracted—I'd prefer to discuss it and deliver separately with more visibility and naturally, no way of cherry-picking. 🙈

I think that having the intermediate "Invalid date" step doesn't hurt and we create the "error" state, while we are entering data.
IMHO, this release is going to have many BCs as it is, I feel like it would be best to omit it at least from v8 if it's not essential. 🤷
WDYT? 🤔

[fields] Always use props.value as the source of truth when defined

3ffc474

flaviendelangle added bug 🐛 Something doesn't work component: pickers This is the name of the generic UI component, not the React module! labels Dec 13, 2024

flaviendelangle self-assigned this Dec 13, 2024

flaviendelangle added 4 commits December 13, 2024 15:46

Work

7cfbf42

Work

b12af13

Work

cfbc49a

Fix

7d704de

flaviendelangle changed the title ~~[fields] Always use props.value as the source of truth when defined~~ [fields] Always use props.value as the source of truth when defined Dec 14, 2024

flaviendelangle added 18 commits December 17, 2024 12:38

Merge branch 'master' into value-field-source-of-truth

9341290

Fix tests

493efaf

Fix tests

a90f089

Merge branch 'master' into value-field-source-of-truth

feaea72

Fix

324cc6a

Fix tests

a469130

Fix tests

3292bf3

Merge branch 'master' into value-field-source-of-truth

1c4ddb7

Fix tests

ff48599

Fix tests

595c548

Fix tests

567019b

Merge branch 'master' into value-field-source-of-truth

1cae5b3

Merge branch 'master' into value-field-source-of-truth

72ef3ec

Fix doc example

3636c29

Fix e2e test

7cb5d04

Fix e2e test

83bae62

Fix CI

36a9ecb

Add tests

47cb95d

flaviendelangle force-pushed the value-field-source-of-truth branch from 169db6a to 4c89824 Compare December 18, 2024 16:08

Add deprecation message

4a2952e

flaviendelangle force-pushed the value-field-source-of-truth branch from 4c89824 to 4a2952e Compare December 18, 2024 16:17

flaviendelangle added 6 commits December 19, 2024 10:15

Merge branch 'master' into value-field-source-of-truth

9279293

Add test for range fields

585cfbd

Merge branch 'master' into value-field-source-of-truth

7102108

Merge branch 'master' into value-field-source-of-truth

a6002ad

Fix

9727183

Merge remote-tracking branch 'origin/value-field-source-of-truth' int…

e4cb9a1

…o value-field-source-of-truth

flaviendelangle marked this pull request as ready for review December 20, 2024 13:04

flaviendelangle requested review from LukasTy and noraleonte December 20, 2024 13:04

flaviendelangle commented Dec 20, 2024

View reviewed changes

github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Dec 30, 2024

Merge

ff0d7cf

github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Dec 30, 2024

Merge branch 'master' into value-field-source-of-truth

f27f8df

github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Jan 2, 2025

Merge

245f6bf

github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Jan 2, 2025

LukasTy added the regression A bug, but worse label Jan 24, 2025

LukasTy reviewed Jan 24, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[fields] Always use `props.value` as the source of truth when defined #15875

[fields] Always use `props.value` as the source of truth when defined #15875

flaviendelangle commented Dec 13, 2024 •

edited

Loading

mui-bot commented Dec 13, 2024 •

edited

Loading

flaviendelangle Dec 20, 2024

flaviendelangle Dec 20, 2024

flaviendelangle Dec 20, 2024

flaviendelangle Dec 20, 2024

flaviendelangle Dec 20, 2024

github-actions bot commented Dec 30, 2024

github-actions bot commented Jan 2, 2025

LukasTy commented Jan 24, 2025

LukasTy left a comment

flaviendelangle commented Jan 24, 2025

flaviendelangle commented Jan 24, 2025

LukasTy commented Jan 27, 2025

[fields] Always use props.value as the source of truth when defined #15875

Are you sure you want to change the base?

[fields] Always use props.value as the source of truth when defined #15875

Conversation

flaviendelangle commented Dec 13, 2024 • edited Loading

Follow up

mui-bot commented Dec 13, 2024 • edited Loading

flaviendelangle Dec 20, 2024

Choose a reason for hiding this comment

flaviendelangle Dec 20, 2024

Choose a reason for hiding this comment

flaviendelangle Dec 20, 2024

Choose a reason for hiding this comment

flaviendelangle Dec 20, 2024

Choose a reason for hiding this comment

flaviendelangle Dec 20, 2024

Choose a reason for hiding this comment

github-actions bot commented Dec 30, 2024

github-actions bot commented Jan 2, 2025

LukasTy commented Jan 24, 2025

LukasTy left a comment

Choose a reason for hiding this comment

flaviendelangle commented Jan 24, 2025

flaviendelangle commented Jan 24, 2025

LukasTy commented Jan 27, 2025

[fields] Always use `props.value` as the source of truth when defined #15875

[fields] Always use `props.value` as the source of truth when defined #15875

flaviendelangle commented Dec 13, 2024 •

edited

Loading

mui-bot commented Dec 13, 2024 •

edited

Loading