[DataGrid] Replace forwardRef with a shim for forward compatibility

[lauri865]

• I have followed (at least) the PR section of the contributing guide.

Fixes #15770

The shim asserts that Ref is always part of the render function props (even if that is not the case in older versions), this is to force typescript to warn us in case we're accidentally spreading over the ref. Refactored everything to have ref as the last prop as a result:

Ref warning doesn't work with slotProps though currently, as they take a slice of the props without the ref. But that can be improved as well I suppose to avoid any footguns.

[mui-bot]

Deploy preview: https://deploy-preview-15955--material-ui-x.netlify.app/

Generated by 🚫 dangerJS against 6c788e6

[lauri865]

I'm not exactly sure why docs:api started failing, but the culprit is GridToolbarDensitySelector component.

[github-actions]

This pull request has conflicts, please resolve those before we can evaluate the pull request.

[arminmeh]

FYI @mui/x
You can use this in other components as well

[oliviertassinari]

Should we do the same in http://github.com/mui/material-ui and https://github.com/mui/base-ui to improve performance?

Or is this meant to be a temporary workaround for a regression in React 19?

[cherniavskii]

Should we do the same in http://github.com/mui/material-ui and mui/base-ui to improve performance?

Yes, I think so 👍🏻

[oliviertassinari]

Looking a bit closer, forwardRef in React 19 looks like this: https://github.com/facebook/react/blob/7aa5dda3b3e4c2baa905a59b922ae7ec14734b24/packages/react/src/ReactForwardRef.js#L51. Almost the same as in React 18.
It seems to create a custom element type. Looking at how React resolves this type internally, I couldn't find obvious source of slowness.

So if this is accurate, we should revert this PR once facebook/react#31613 is fixed.

Edit: OK, there is also need to factor

mui-x/packages/x-internals/src/forwardRef/forwardRef.tsx

Line 7 in 43411bf

// Footgun: <Component ref={ref} {...props} /> will break past React 19, but the types will now warn us that we should use <Component {...props} ref={ref} /> instead.

Don't we have tone of instances of this, e.g.

https://github.com/mui/material-ui/blob/9574765d827b72545a10806db1bb1f7b3d2f54b9/packages/mui-material/src/Rating/Rating.js#L530

https://github.com/mui/material-ui/blob/9574765d827b72545a10806db1bb1f7b3d2f54b9/packages/mui-material/src/ButtonBase/ButtonBase.js#L306

[cherniavskii]

So if this is accurate, we should revert this PR once facebook/react#31613 is fixed.

Chances are it won't be fixed – see #15770 (comment)