Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] Update argos screenshots #16111

Merged
merged 1 commit into from
Jan 9, 2025
Merged

[core] Update argos screenshots #16111

merged 1 commit into from
Jan 9, 2025

Conversation

romgrk
Copy link
Contributor

@romgrk romgrk commented Jan 9, 2025

Update screenshots.

All the differences are due to either minor anti-aliasing changes, or the default width of text inputs which seems to have been lowered.

@romgrk romgrk added the core Infrastructure work going on behind the scenes label Jan 9, 2025
@mui-bot
Copy link

mui-bot commented Jan 9, 2025

Deploy preview: https://deploy-preview-16111--material-ui-x.netlify.app/

Generated by 🚫 dangerJS against af473a0

@romgrk romgrk requested a review from a team January 9, 2025 08:55
@romgrk romgrk enabled auto-merge (squash) January 9, 2025 08:56
@alexfauquette
Copy link
Member

@romgrk Could you explain what you did / what this PR is testing?

Because asking for a review on an empty PR is a bit weird 😄
I assume you modified some Argos config, but I don't know where to look

@romgrk
Copy link
Contributor Author

romgrk commented Jan 9, 2025

I did not modify anything. Argos started failing without any change on our side, this means there is a hidden dependency that has been updated, for example the virtual machine OS on which argos runs could have been updated to use a new version of libharfbuzz or whatnot.

@romgrk romgrk disabled auto-merge January 9, 2025 09:11
Copy link
Member

@LukasTy LukasTy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, all changes look flaky that we can accept if it's failing in all other PRs. 👌

@romgrk romgrk merged commit 3b0bba2 into mui:master Jan 9, 2025
20 checks passed
@romgrk romgrk deleted the ci-argos-update branch January 9, 2025 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Infrastructure work going on behind the scenes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants