Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[charts] Replace tooltip mark with style #16117

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

JCQuintas
Copy link
Member

@JCQuintas JCQuintas commented Jan 9, 2025

before after
Screenshot 2025-01-09 at 20 53 52 Screenshot 2025-01-09 at 20 53 33
Screenshot 2025-01-09 at 20 56 26 Screenshot 2025-01-09 at 20 53 05

Changelog

  • Charts tooltip markers now have different styles for each chart type. The tooltip and legend marks are now the same.

@JCQuintas JCQuintas added enhancement This is not a bug, nor a new feature component: charts This is the name of the generic UI component, not the React module! labels Jan 9, 2025
@JCQuintas JCQuintas self-assigned this Jan 9, 2025
@@ -57,6 +57,7 @@ const formatter: SeriesFormatter<'bar'> = (params, dataset) => {
const dataKey = series[id].dataKey;
completedSeries[id] = {
layout: 'vertical',
labelMarkType: 'square',
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moved markType default from legend getter to series formatter as the tooltip doesn't use the legend getter

@mui-bot
Copy link

mui-bot commented Jan 9, 2025

Deploy preview: https://deploy-preview-16117--material-ui-x.netlify.app/

Updated pages:

Generated by 🚫 dangerJS against f728aef

Copy link

codspeed-hq bot commented Jan 9, 2025

CodSpeed Performance Report

Merging #16117 will not alter performance

Comparing JCQuintas:add-new-markers-to-tooltip (f728aef) with master (6412b8c)

Summary

✅ 6 untouched benchmarks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: charts This is the name of the generic UI component, not the React module! enhancement This is not a bug, nor a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants