Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[core] Type all references as RefObject #16124

Merged
merged 1 commit into from
Jan 10, 2025
Merged

[core] Type all references as RefObject #16124

merged 1 commit into from
Jan 10, 2025
+245 −255

Conversation

arminmeh
Copy link
Contributor

Fixes #16116

I have updated all references to be RefObject

@arminmeh arminmeh added component: data grid This is the name of the generic UI component, not the React module! typescript component: tree view TreeView, TreeItem. This is the name of the generic UI component, not the React module! needs cherry-pick The PR should be cherry-picked to master after merge v7.x React 19 support About improving React 19 support labels Jan 10, 2025
@mui-bot
Copy link

mui-bot commented Jan 10, 2025

Deploy preview: https://deploy-preview-16124--material-ui-x.netlify.app/

Generated by 🚫 dangerJS against af1af49

@arminmeh arminmeh added plan: Pro Impact at least one Pro user plan: Premium Impact at least one Premium user labels Jan 10, 2025
@LukasTy LukasTy changed the title [core] All references typed as RefObject [core] Type all references as RefObject Jan 10, 2025
LukasTy
LukasTy approved these changes Jan 10, 2025
View reviewed changes
Copy link
Member

@LukasTy LukasTy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. 👌
Thank you for taking care of it. 🙏
I completely forgot about this deprecated type after React 19 migration. 😢

@arminmeh arminmeh merged commit 7541f95 into mui:master Jan 10, 2025
34 checks passed
@arminmeh arminmeh deleted the apiref-type branch January 10, 2025 10:55
@github-actions GitHub Actions
Copy link

Cherry-pick PRs will be created targeting branches: v7.x

@arminmeh arminmeh mentioned this pull request Jan 10, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LukasTy LukasTy LukasTy approved these changes

@flaviendelangle flaviendelangle Awaiting requested review from flaviendelangle

@cherniavskii cherniavskii Awaiting requested review from cherniavskii

Assignees
No one assigned
Labels
component: data grid This is the name of the generic UI component, not the React module! component: tree view TreeView, TreeItem. This is the name of the generic UI component, not the React module! needs cherry-pick The PR should be cherry-picked to master after merge plan: Premium Impact at least one Premium user plan: Pro Impact at least one Pro user React 19 support About improving React 19 support typescript v7.x
Projects
None yet
Milestone
No milestone
3 participants
@arminmeh @mui-bot @LukasTy