Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pickers] Do not close the picker when doing keyboard editing #16402

Merged
merged 1 commit into from
Jan 31, 2025

Conversation

flaviendelangle
Copy link
Member

Noticed this regression while working on #16175
In range picker, you can edit the field when the view is opened, and it would automatically close the view when doing it.

@flaviendelangle flaviendelangle added bug 🐛 Something doesn't work component: pickers This is the name of the generic UI component, not the React module! labels Jan 30, 2025
@flaviendelangle flaviendelangle self-assigned this Jan 30, 2025
@flaviendelangle flaviendelangle marked this pull request as ready for review January 30, 2025 13:07
@mui-bot
Copy link

mui-bot commented Jan 30, 2025

Deploy preview: https://deploy-preview-16402--material-ui-x.netlify.app/

Generated by 🚫 dangerJS against 2f0e1fb

Copy link
Member

@LukasTy LukasTy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. 👍
It would be great to have a test covering this behavior. 🙈

@LukasTy
Copy link
Member

LukasTy commented Jan 31, 2025

It would be great to have a test covering this behavior. 🙈

Oh, it seems we have it, it's just not asserting exactly this and thus failing flakily. 🙈
https://app.circleci.com/pipelines/github/mui/mui-x/80165/workflows/84efc2d8-f5de-4122-8ea0-2d67fa336750/jobs/456376

@flaviendelangle
Copy link
Member Author

I will cleanup the opening / closing test once we have the new opening structure for the range field, it will be a good opportunity 👍

@flaviendelangle flaviendelangle merged commit 099602f into mui:master Jan 31, 2025
22 checks passed
@flaviendelangle flaviendelangle deleted the not-close-picker branch January 31, 2025 13:31
A-s-h-o-k pushed a commit to A-s-h-o-k/mui-x that referenced this pull request Feb 4, 2025
JCQuintas pushed a commit to JCQuintas/mui-x that referenced this pull request Feb 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something doesn't work component: pickers This is the name of the generic UI component, not the React module!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants