Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[core] Update to Node v18 for l10n GitHub CI #9355

Merged
merged 1 commit into from
Jun 16, 2023
Merged

[core] Update to Node v18 for l10n GitHub CI #9355

merged 1 commit into from
Jun 16, 2023

Conversation

ZeeshanTamboli
Copy link
Member

@ZeeshanTamboli ZeeshanTamboli commented Jun 16, 2023 •
edited
Loading

Came from mui/material-ui#37604 to ensure consistency. This job runs only on master and next branches.

@ZeeshanTamboli ZeeshanTamboli added core Infrastructure work going on behind the scenes dependencies Update of dependencies labels Jun 16, 2023
@ZeeshanTamboli ZeeshanTamboli marked this pull request as ready for review June 16, 2023 07:26
@mui-bot
Copy link

mui-bot commented Jun 16, 2023

Netlify deploy preview

Netlify deploy preview: https://deploy-preview-9355--material-ui-x.netlify.app/

Updated pages

No updates.

These are the results for the performance tests:

Test case Unit Min Max Median Mean σ
Filter 100k rows ms 645.8 1,341.9 645.8 953.2 257.399
Sort 100k rows ms 701.1 1,379.1 1,263 1,135.5 232.406
Select 100k rows ms 249.2 589.8 337.2 373.4 115.01
Deselect 100k rows ms 157.7 389.5 307.6 301.72 78.664

Generated by 🚫 dangerJS against cf26f41

LukasTy
LukasTy approved these changes Jun 16, 2023
View reviewed changes
Copy link
Member

@LukasTy LukasTy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like this is a workflow that is run on every merge to master branch and it's job is to update the #3211 description with l10n status.

@ZeeshanTamboli
Copy link
Member Author

It looks like this is a workflow that is run on every merge to master branch and it's job is to update the #3211 description with l10n status.

Thanks. Yes, I realized it now before you approved.

@ZeeshanTamboli ZeeshanTamboli enabled auto-merge (squash) June 16, 2023 07:42
@ZeeshanTamboli ZeeshanTamboli disabled auto-merge June 16, 2023 07:42
@ZeeshanTamboli ZeeshanTamboli merged commit 5350da5 into mui:master Jun 16, 2023
@ZeeshanTamboli ZeeshanTamboli deleted the use-node-18-on-l10n-github-action branch June 16, 2023 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LukasTy LukasTy LukasTy approved these changes

Assignees
No one assigned
Labels
core Infrastructure work going on behind the scenes dependencies Update of dependencies
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ZeeshanTamboli @mui-bot @LukasTy