Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Client-side fetch queries #1252

Merged
merged 11 commits into from
Nov 4, 2022
Merged

Client-side fetch queries #1252

merged 11 commits into from
Nov 4, 2022

Conversation

Janpot
Copy link
Member

@Janpot Janpot commented Oct 31, 2022

Attempt at adding a browserside mode to fetch queries:

Screen.Recording.2022-10-31.at.13.42.01.mov

Drawbacks of this method

  • There is no way to get more diagnostics on failed fetches than "Failed to fetch". No way to find out whether it's because of CORs, or because of a firewall, or because of a DNS not resolving,...
  • We can't supply the same information in the network tab as we can for serverside fetches. Currently it shows url, and some of the response headers. It can't show:
    • cookies
    • request headers
    • body sizes
    • timings
    • HTTP version
    • IP addresses

This only adds the mode, it doesn't yet update how the demo handles fetch requests

@render
Copy link

render bot commented Oct 31, 2022

@Janpot Janpot marked this pull request as ready for review November 3, 2022 11:48
@Janpot Janpot merged commit e8c0940 into master Nov 4, 2022
@Janpot Janpot deleted the WIP-client-fetch branch November 4, 2022 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants