Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs] Fix images width overflow on Firefox #2874

Merged
merged 1 commit into from
Nov 7, 2023
Merged

[docs] Fix images width overflow on Firefox #2874

merged 1 commit into from
Nov 7, 2023

Conversation

bharatkashyap
Copy link
Member

Before After
Screenshot 2023-11-06 at 3 12 52 PM Screenshot 2023-11-06 at 3 13 20 PM

@bharatkashyap bharatkashyap added docs Improvements or additions to the documentation bug 🐛 Something doesn't work labels Nov 6, 2023
Janpot
Janpot approved these changes Nov 6, 2023
View reviewed changes
Copy link
Member

@Janpot Janpot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any idea about what firefox is doing differently?

@bharatkashyap
Copy link
Member Author

Any idea about what firefox is doing differently?

I feel it might be related to this issue in Firefox where in the absence of an explicit max-width, it sets width to be max-content, but I could be wrong: https://bugzilla.mozilla.org/show_bug.cgi?id=1670151

@bharatkashyap bharatkashyap merged commit 58deb57 into mui:master Nov 7, 2023
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Janpot Janpot Janpot approved these changes

Assignees
No one assigned
Labels
bug 🐛 Something doesn't work docs Improvements or additions to the documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[docs] Images seem to be broken on Firefox
2 participants
@bharatkashyap @Janpot