-
-
Notifications
You must be signed in to change notification settings - Fork 324
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Protect runtime RPC with authorization #3034
Conversation
1cccd98
to
741b8e3
Compare
@Janpot I'm getting an error here due to the types I created and I'm not even sure if this is a good way to protect queries from users without the correct roles, or if there is a better way we should do it... Let me know what you think, there's a lot of things in these parts of the code that you probably understand better than me. |
So I'd say:
|
Sounds good, thanks! I'll probably close this PR for now then, and can add |
Closing, I'll create issues later for the features that were suggested instead of this implementation. |
On query requests to the runtime RPC, require that a user has the required roles according to the page the query is called from.
Includes a few refactors too.