[code-infra] Polish VS Code DX #4562
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliviertassinari
added
scope: code-infra
| "editor.codeActionsOnSave": { | ||
| "source.fixAll.eslint": "explicit" | ||
| }, | ||
| "editor.formatOnSave": true, |
There was a problem hiding this comment.
How mui/material-ui#44865 started, I was annoyed by this setting. It felt too opinionated to be shared with everyone.
bharatkashyap
approved these changes
Dec 27, 2024
oliviertassinari
commented
Jan 3, 2025
Signed-off-by: Olivier Tassinari <[email protected]>
Janpot
reviewed
Jan 4, 2025
|
|
||
| # Unix-style newlines with a newline ending every file | ||
| [*] | ||
| trim_trailing_whitespace = true |
There was a problem hiding this comment.
isn't this already defined by prettier config? i.e. you need to set up your editor to format/highlight with a prettier extension instead. feels a bit redundant to define this twice
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mui/material-ui#44865