-
-
Notifications
You must be signed in to change notification settings - Fork 317
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PageHeader] Allow multiple breadcrumbs that are not links #4571
Conversation
Signed-off-by: Rafael Grigorian <[email protected]>
Signed-off-by: Rafael Grigorian <[email protected]>
Signed-off-by: Rafael Grigorian <[email protected]>
Changing key for Typography breadcrumb from `item.title` to `index` Signed-off-by: Rafael Grigorian <[email protected]>
Netlify deploy preview |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, approved too fast. Let's use the same key everywhere. Also, can the path
property be made optional now in the BreadCrumb
type?
Co-authored-by: Jan Potoms <[email protected]> Signed-off-by: Rafael Grigorian <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thank you!
Simply allows multiple breadcrumbs to exist that are not links. An application of this would be having a top level breadcrumb that you would not want to be a link but instead be static text.
For example, given this definition for breadcrumbs:
Before, the last breadcrumb was always static text and all breadcrumbs before it were links.
After, the breadcrumb is a link if it has a truthy value for
path
and it is static text if that value ofpath
is falsy.