Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[code-infra] Update package layout for ESM #4686

Open
wants to merge 16 commits into
base: master
Choose a base branch
from
Open

[code-infra] Update package layout for ESM #4686

wants to merge 16 commits into from

Conversation

Janpot
Copy link
Member

@Janpot Janpot commented Feb 19, 2025 •
edited
Loading

Fixes #4675.

Bring in mui/material-ui#43264 for core and utils. ignoring the studio packages for now.

  • had to convert @toolpad/utils as well as it's a dependency of @toolpad/core
  • had to update monorepo, which had a bunch of hanging changes:
    • bring in changes for docs/config update
    • bring in changes for next.config.ts
    • bring eslint update
  • updated core lib to be able to remove the labs dependency, this fixes issues of lab not being a peer dependency

@Janpot Janpot added the scope: code-infra Specific to the core-infra product label Feb 19, 2025
@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Feb 19, 2025
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Feb 19, 2025
@mui-bot
Copy link

mui-bot commented Feb 19, 2025 •
edited
Loading

Netlify deploy preview

https://deploy-preview-4686--mui-toolpad-docs.netlify.app/

Generated by 🚫 dangerJS against b5c4868

@Janpot Janpot mentioned this pull request Feb 19, 2025
Open
@Janpot Janpot marked this pull request as ready for review February 19, 2025 17:40
@Janpot Janpot mentioned this pull request Feb 19, 2025
Closed
@Janpot Janpot requested a review from a team February 19, 2025 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
scope: code-infra Specific to the core-infra product
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Import error when using Material UI styles with React router v7 framework
2 participants
@Janpot @mui-bot