W-17457827: JPMS support for the RevAPI plugin. #172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
SonarQube Quality Gate
|
elrodro83
requested changes
Jan 3, 2025
| Set<ExportedPackages> exportedPackages = new HashSet<>(); | ||
| api.getArchives().forEach(archive -> { | ||
| if (!addJavaModuleSystemExportedPackages(api, archive, exportedPackages)) { | ||
| if (!addMuleModuleSystemExportedPackages(archive, exportedPackages)) { |
There was a problem hiding this comment.
use && instead of nested ifs
| } | ||
|
|
||
| private boolean addMuleModuleSystemExportedPackages(Archive archive, Set<ExportedPackages> exportedPackages) { | ||
| if (isMixedMode() || isMuleMode()) { |
There was a problem hiding this comment.
shouldn't isMuleMode checked for mixed mode as well?
| } | ||
|
|
||
| private boolean addJavaModuleSystemExportedPackages(API api, Archive archive, Set<ExportedPackages> exportedPackages) { | ||
| if (isJavaMode() || isMixedMode()) { |
There was a problem hiding this comment.
shouldn't isJavaMode checked for mixed mode as well?
|
|
||
| boolean isExported(String packageName); | ||
|
|
||
| void logExportedPackages(); |
There was a problem hiding this comment.
why this is weird... by the name this seems to be a value object... why does it have logging behaviour?
|
|
||
| public interface ExportedPackages { | ||
|
|
||
| boolean isExported(String packageName); |
| if (moduleReferences.isEmpty()) { | ||
| return empty(); | ||
| } else { | ||
| return Optional.of(moduleReferences.iterator().next()); |
Comment on lines
+67
to
+69
| Field archiveFile = archive.getClass().getDeclaredField("file"); | ||
| archiveFile.setAccessible(true); | ||
| return ((File) archiveFile.get(archive)).toPath(); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.