Add negative leak test #6448
Closed
Add negative leak test #6448
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a negative leak test. This is a draft PR. The implementation should almost be there, but the main issue with the test right now seems to be that
getConnectedThroughRelayDateIntervalis returning a longer date interval for the relay connection than expected. I believe its a bug in the test code but it could also be that the dummy data is incorrect. Had to work with dummy data because of the ongoing move.To try it out run
testNegativeLeaksunderLeakTests. The test device must be connected to theapp-team-ios-testsWiFi to be able to reach the packet capture API and firewall API.This change is