Update changelog presentation

[kl]

---

This change is 

[linear]

DROID-1634 Update changelog presentation

[Pururun]

Reviewed 20 of 20 files at r1, 1 of 1 files at r2.
Reviewable status: 19 of 21 files reviewed, 2 unresolved discussions (waiting on @kl)

---

android/app/src/main/kotlin/net/mullvad/mullvadvpn/compose/component/notificationbanner/NotificationData.kt line 42 at r2 (raw file):

    ) : this(
        AnnotatedString(title),
        message?.let { NotificationMessage.Text(AnnotatedString(it)) },

This is just a general comment about clickable text, but any reason we did use an icon as for external links instead of the clickable text?

---

android/app/src/main/kotlin/net/mullvad/mullvadvpn/usecase/NewChangelogNotificationUseCase.kt line 18 at r2 (raw file):

    operator fun invoke() =
        combine(
                userPreferencesRepository.preferencesFlow,

Do we need to consider ALWAYS\_SHOW\_CHANGELOG or do we already do that in the repository? Maybe that property is not longer relevant?

[kl]

Reviewable status: 19 of 21 files reviewed, 2 unresolved discussions (waiting on @Pururun)

---

android/app/src/main/kotlin/net/mullvad/mullvadvpn/compose/component/notificationbanner/NotificationData.kt line 42 at r2 (raw file):

Previously, Pururun (Jonatan Rhodin) wrote…

This is just a general comment about clickable text, but any reason we did use an icon as for external links instead of the clickable text?

We already have one clickable icon in that view (the X to close the notification), so maybe strange to have more?

---

android/app/src/main/kotlin/net/mullvad/mullvadvpn/usecase/NewChangelogNotificationUseCase.kt line 18 at r2 (raw file):

Previously, Pururun (Jonatan Rhodin) wrote…

Do we need to consider ALWAYS\_SHOW\_CHANGELOG or do we already do that in the repository? Maybe that property is not longer relevant?

Good question!

[kl]

Reviewable status: 19 of 23 files reviewed, 2 unresolved discussions (waiting on @Pururun)

---

android/app/src/main/kotlin/net/mullvad/mullvadvpn/usecase/NewChangelogNotificationUseCase.kt line 18 at r2 (raw file):

Previously, kl (Kalle Lindström) wrote…

Good question!

Removed in latest commit

[albin-mullvad]

Reviewed 3 of 20 files at r1, 2 of 2 files at r4, 2 of 2 files at r5.
Reviewable status: all files reviewed, 4 unresolved discussions (waiting on @kl and @Pururun)

---

android/lib/resource/src/main/res/values/strings.xml line 179 at r5 (raw file):

    </string>
    <string name="new_changelog_notification_title">NEW VERSION INSTALLED</string>
    <string name="new_changelog_notification_message">Click here to see what\'s new.</string>

See other comment regarding curly apostrophes

Code quote:

what\'s

---

android/lib/resource/src/main/res/values/strings.xml line 392 at r5 (raw file):

    <string name="share">Share…</string>
    <string name="app_info">App info</string>
    <string name="changelog_title">What\'s new</string>

I believe this string is incorrect since we should only use curly apostrophes (’). We also shouldn't need the backslash.

For example see this previous issue: https://linear.app/mullvad/issue/DROID-1290

Code quote:

What\'s new

[Pururun]

Reviewed 2 of 2 files at r4, 2 of 2 files at r5, all commit messages.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @kl)

---

android/app/src/main/kotlin/net/mullvad/mullvadvpn/compose/component/notificationbanner/NotificationData.kt line 42 at r2 (raw file):

Previously, kl (Kalle Lindström) wrote…

We already have one clickable icon in that view (the X to close the notification), so maybe strange to have more?

Right I did not considered the close button, in that case it is all good!

---

android/app/src/main/kotlin/net/mullvad/mullvadvpn/usecase/NewChangelogNotificationUseCase.kt line 11 at r5 (raw file):

import net.mullvad.mullvadvpn.repository.UserPreferencesRepository

class NewChangelogNotificationUseCase(

This should considered if we actually have anything in the changelog. Should probably not notify if we have an empty changelog.

[Rawa]

Reviewable status: 18 of 25 files reviewed, 3 unresolved discussions (waiting on @albin-mullvad, @kl, and @Pururun)

---

android/lib/resource/src/main/res/values/strings.xml line 179 at r5 (raw file):

Previously, albin-mullvad wrote…

See other comment regarding curly apostrophes

Fixed, but we need to notify desktop team since they use the wrong apostrophes on these strings.

---

android/lib/resource/src/main/res/values/strings.xml line 392 at r5 (raw file):

Previously, albin-mullvad wrote…

I believe this string is incorrect since we should only use curly apostrophes (’). We also shouldn't need the backslash.

For example see this previous issue: https://linear.app/mullvad/issue/DROID-1290

Fixed, but we need to notify desktop team since they use the wrong apostrophes on these strings.

[Rawa]

Reviewable status: 18 of 25 files reviewed, 3 unresolved discussions (waiting on @albin-mullvad and @Pururun)

---

android/app/src/main/kotlin/net/mullvad/mullvadvpn/usecase/NewChangelogNotificationUseCase.kt line 11 at r5 (raw file):

Previously, Pururun (Jonatan Rhodin) wrote…

This should considered if we actually have anything in the changelog. Should probably not notify if we have an empty changelog.

Fixed

[Pururun]

Reviewed 2 of 7 files at r6, 24 of 29 files at r8, 9 of 9 files at r9, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @albin-mullvad)

[Rawa]

Reviewed 6 of 20 files at r1, 1 of 2 files at r4, 2 of 2 files at r5, 2 of 7 files at r6, 4 of 29 files at r8, 5 of 9 files at r9, 26 of 26 files at r10, all commit messages.
Reviewable status: all files reviewed, 5 unresolved discussions (waiting on @albin-mullvad and @kl)

---

android/app/src/main/proto/user_prefs.proto line 8 at r10 (raw file):

message UserPreferences {
  bool is_privacy_disclosure_accepted = 1;
  int32 version_code_for_latest_shown_changelog_notification = 2;

Maybe can be a bit simpler name
last_shown_changelog_version_code
or
version_code_for_last_shown_changelog

---

android/app/src/main/kotlin/net/mullvad/mullvadvpn/compose/screen/AppInfoScreen.kt line 106 at r10 (raw file):

    Column(modifier = Modifier.padding(bottom = Dimens.smallPadding).animateContentSize()) {
        ChangelogRow(navigateToChangelog)
        HorizontalDivider(color = Color.Transparent)

Why do we add a transparent Divider? 🙃

---

android/app/src/main/kotlin/net/mullvad/mullvadvpn/compose/screen/ChangelogScreen.kt line 65 at r10 (raw file):

    ChangelogScreen(
        uiState.value,
        onBackClick = { navController.navigateUp() },

navController::navigateUp

[Rawa]

Reviewed 1 of 1 files at r11.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @albin-mullvad and @kl)

---

android/app/src/main/kotlin/net/mullvad/mullvadvpn/compose/screen/AppInfoScreen.kt line 106 at r10 (raw file):

Previously, Rawa (David Göransson) wrote…

Why do we add a transparent Divider? 🙃

Fixed

---

android/app/src/main/kotlin/net/mullvad/mullvadvpn/compose/screen/ChangelogScreen.kt line 65 at r10 (raw file):

Previously, Rawa (David Göransson) wrote…

navController::navigateUp

Fixed

[kl]

Reviewable status: 42 of 46 files reviewed, 3 unresolved discussions (waiting on @albin-mullvad, @Pururun, and @Rawa)

---

android/app/src/main/proto/user_prefs.proto line 8 at r10 (raw file):

Previously, Rawa (David Göransson) wrote…

Maybe can be a bit simpler name
last_shown_changelog_version_code
or
version_code_for_last_shown_changelog

Done.

[Rawa]

Reviewed 1 of 1 files at r12, 3 of 3 files at r13, 7 of 7 files at r14, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @albin-mullvad)

[olmoh]

Reviewed 3 of 3 files at r15, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved

[albin-mullvad]

Reviewed 1 of 7 files at r14, 3 of 3 files at r15, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved