-
Notifications
You must be signed in to change notification settings - Fork 357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move management interface to its own package #7399
base: main
Are you sure you want to change the base?
Move management interface to its own package #7399
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So nice!! 🔥 🙌
Reviewed 13 of 13 files at r1, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved
desktop/packages/management-interface/package.json
line 6 at r1 (raw file):
"author": "Mullvad VPN", "license": "GPL-3.0", "description": "",
⛏️ Could we add a quick description of this module? The mullvad-management-interface
crate has the following description
Mullvad VPN IPC. Contains types and functions for IPC clients and servers.
Maybe we could write something similar here? 😊
Code quote:
"description": "",
a12e71d
to
a9cbba1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 12 of 13 files reviewed, all discussions resolved (waiting on @MarkusPettersson98)
desktop/packages/management-interface/package.json
line 6 at r1 (raw file):
Previously, MarkusPettersson98 (Markus Pettersson) wrote…
⛏️ Could we add a quick description of this module? The
mullvad-management-interface
crate has the following descriptionMullvad VPN IPC. Contains types and functions for IPC clients and servers.
Maybe we could write something similar here? 😊
Done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved
a9cbba1
to
703693b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job! 🔥
Reviewed 12 of 13 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @raksooo)
desktop/packages/management-interface/src/index.ts
line 1 at r2 (raw file):
export * from '../dist/management_interface_grpc_pb';
"Exporting from dist
feels a bit unusual. An alternative would be to keep the generated files checked into source so they can be referenced directly. However, from what I understand other parts of the repo follow this pattern, and if so I think we should keep it consistent.
703693b
to
22d9356
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @raksooo)
22d9356
to
5ea072d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had to make some changes to packages/management-interface/package.json
to make it all work on Windows.
Reviewable status: 12 of 13 files reviewed, 1 unresolved discussion (waiting on @MarkusPettersson98 and @olmoh)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r4, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @raksooo)
This PR moves the gRPC code generation for the management interface into its own npm package. This makes the file structure, build process and usage cleaner and easier to follow.
This change is