-
Notifications
You must be signed in to change notification settings - Fork 372
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove debug symbols for aab bundles #7520
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @Pururun)
-- commits
line 2 at r1:
nit: debug symbols
Code quote:
debugsymbols
android/app/build.gradle.kts
line 49 at r1 (raw file):
minSdk = Versions.minSdkVersion targetSdk = Versions.targetSdkVersion ndk { debugSymbolLevel = "none" }
I suggest moving it down under the lint section.
Also, should we perhaps keep it enabled for certain builds?
Code quote:
ndk { debugSymbolLevel = "none" }
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @albin-mullvad and @Pururun)
android/app/build.gradle.kts
line 49 at r1 (raw file):
Previously, albin-mullvad wrote…
I suggest moving it down under the lint section.
Also, should we perhaps keep it enabled for certain builds?
I agree, we could check if it a release build and then set it to "none"
.
d6e9d3f
to
9ef3a9f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @albin-mullvad and @Rawa)
Previously, albin-mullvad wrote…
nit:
debug symbols
Done
android/app/build.gradle.kts
line 49 at r1 (raw file):
Previously, Rawa (David Göransson) wrote…
I agree, we could check if it a release build and then set it to
"none"
.
Done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @Rawa)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r2.
Reviewable status: complete! all files reviewed, all discussions resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved
9ef3a9f
to
ca68717
Compare
This change is