Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove debug symbols for aab bundles #7520

Merged
merged 1 commit into from
Jan 27, 2025

Conversation

Pururun
Copy link
Contributor

@Pururun Pururun commented Jan 24, 2025


This change is Reviewable

@Pururun Pururun added the Android Issues related to Android label Jan 24, 2025
@Pururun Pururun requested review from kl and albin-mullvad January 24, 2025 13:49
Copy link

linear bot commented Jan 24, 2025

Copy link
Collaborator

@albin-mullvad albin-mullvad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @Pururun)


-- commits line 2 at r1:
nit: debug symbols

Code quote:

debugsymbols 

android/app/build.gradle.kts line 49 at r1 (raw file):

        minSdk = Versions.minSdkVersion
        targetSdk = Versions.targetSdkVersion
        ndk { debugSymbolLevel = "none" }

I suggest moving it down under the lint section.

Also, should we perhaps keep it enabled for certain builds?

Code quote:

ndk { debugSymbolLevel = "none" }

Copy link
Contributor

@Rawa Rawa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @albin-mullvad and @Pururun)


android/app/build.gradle.kts line 49 at r1 (raw file):

Previously, albin-mullvad wrote…

I suggest moving it down under the lint section.

Also, should we perhaps keep it enabled for certain builds?

I agree, we could check if it a release build and then set it to "none".

@Pururun Pururun force-pushed the unexpected-aab-size-increase-droid-1752 branch from d6e9d3f to 9ef3a9f Compare January 27, 2025 08:05
Copy link
Contributor Author

@Pururun Pururun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @albin-mullvad and @Rawa)


-- commits line 2 at r1:

Previously, albin-mullvad wrote…

nit: debug symbols

Done


android/app/build.gradle.kts line 49 at r1 (raw file):

Previously, Rawa (David Göransson) wrote…

I agree, we could check if it a release build and then set it to "none".

Done

@albin-mullvad albin-mullvad requested a review from Rawa January 27, 2025 08:27
Copy link
Collaborator

@albin-mullvad albin-mullvad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @Rawa)

Copy link
Contributor

@Rawa Rawa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r2.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@Pururun Pururun changed the title Remove debugsymbols for aab bundles Remove debug symbols for aab bundles Jan 27, 2025
Copy link
Contributor

@Rawa Rawa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@Pururun Pururun force-pushed the unexpected-aab-size-increase-droid-1752 branch from 9ef3a9f to ca68717 Compare January 27, 2025 10:03
@Pururun Pururun merged commit f8b5565 into main Jan 27, 2025
28 checks passed
@Pururun Pururun deleted the unexpected-aab-size-increase-droid-1752 branch January 27, 2025 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Android Issues related to Android
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants