Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run the git commit message style CI on PRs #73

Closed
wants to merge 1 commit into from

Conversation

faern
Copy link
Member

@faern faern commented Jan 23, 2025

It was previously set to run on pushes only, and that did not trigger on third party PRs, only on PRs on branches in the original repository


This change is Reviewable

@faern faern requested a review from hulthe January 23, 2025 08:48
It was previously set to run on pushes only, and that did not trigger
on third party PRs, only on PRs on branches in the original repository
@faern faern force-pushed the run-git-commit-message-check-on-pr branch from 1926a02 to 63736c6 Compare January 23, 2025 08:49
@faern
Copy link
Member Author

faern commented Jan 23, 2025

Ah, dang. I forgot that this action, if set to run on pull_request also unconditionally checks the PR message here on github. Which is unreasonable to follow the same formatting standards as the git commit messages. There is no sane reason to limit a line to 72 characters in a web markdown field. The automatically inserted reviewable links will also never adhere to this standard.

@faern faern closed this Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant