-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Some clean-ups #305
Merged
Merged
Some clean-ups #305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These trailing whitespaces are useless characters. Many text editors remove them automatically, and Git also complains about them. Best to remove them to avoid unwanted changes, and warnings. Signed-off-by: Matthieu Baerts (NGI0) <[email protected]>
When checking header files individually, some of them didn't include stdbool.h ('bool' type) or stdint.h (uint32_t type). Add the missing headers to have all these header files self-contained: they can be compiled alone with analytic tools. Signed-off-by: Matthieu Baerts (NGI0) <[email protected]>
'clangd' reported a few unused headers. Best to remove them then. Signed-off-by: Matthieu Baerts (NGI0) <[email protected]>
clangd reported this issue: A function declaration without a prototype is deprecated in all versions of C. We can simply adding 'void', we don't need any arguments there. Signed-off-by: Matthieu Baerts (NGI0) <[email protected]>
Pull Request Test Coverage Report for Build 11531089066Details
💛 - Coveralls |
It is useful to be used with clangd to enhance a text editor. This file can be generated with bear, e.g. $ make clean $ bear --append -- make -j$(nproc) all check While at it, also ignore .plist files: some CLang diagnostics files. Signed-off-by: Matthieu Baerts (NGI0) <[email protected]>
Similar to what is done in the Linux kernel: very likely, hidden files and directories don't need to be tracked in git. There are exceptions of course, like the '.github' directory, but we can always force their inclusions with 'git add -f'. This will at least ignore the '.cache' directory created by clangd. Editors tend to create hidden directories and files too, so that would cover that too. Signed-off-by: Matthieu Baerts (NGI0) <[email protected]>
ossama-othman
approved these changes
Oct 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here are a bunch of different clean-ups I did while working on #304, mostly helped by clangd.