Refactoring MTA code - Part 1 #3340
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Did you manage to compile these changes successfully on any platform, or have you just done a find and replace then submitted a PR? |
Its compiling but Im having some memory violation issues |
TracerDS
force-pushed
the
140324_Refactoring_Part-1
branch
2 times, most recently
from
22f9930 to
97025ef
Compare
TracerDS
force-pushed
the
140324_Refactoring_Part-1
branch
from
97025ef to
2fdcddc
Compare
I hope that this will fix errors in arm builds ;_;
Replaced `FLOAT` with `float`; useless alias
|
Please make these refactorings smaller or concentrate on a single refactoring aspect. Then it's easier to review, merge and test. |
|
Am going to close this one. You can make refactor PRs, but just make them smaller or more concentrated. |
Understood |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently most mta's code uses generic
unsignedtypes which are platform dependent.cstdintheader however is (should be) platform independent.This PR focuses on that irregularity and replaces all
unsigned(and somewherelong long) into thecstdinttypes.MTA's source code is huuge. So there is a gigantic number of changes
Splitting the PR into multiple PR's with the same changes would bring too much troubles