-
-
Notifications
You must be signed in to change notification settings - Fork 452
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactoring MTA code - Part 1 #3340
Refactoring MTA code - Part 1 #3340
Conversation
Did you manage to compile these changes successfully on any platform, or have you just done a find and replace then submitted a PR? |
Its compiling but Im having some memory violation issues |
22f9930
to
97025ef
Compare
97025ef
to
2fdcddc
Compare
I hope that this will fix errors in arm builds ;_;
Replaced `FLOAT` with `float`; useless alias
Please make these refactorings smaller or concentrate on a single refactoring aspect. Then it's easier to review, merge and test. |
Am going to close this one. You can make refactor PRs, but just make them smaller or more concentrated. |
Understood |
Currently most mta's code uses generic
unsigned
types which are platform dependent.cstdint
header however is (should be) platform independent.This PR focuses on that irregularity and replaces all
unsigned
(and somewherelong long
) into thecstdint
types.MTA's source code is huuge. So there is a gigantic number of changes
Splitting the PR into multiple PR's with the same changes would bring too much troubles