onPlayerTeamChange Event #3370
onPlayerTeamChange Event #3370
Conversation
|
How about enabling cancelEvent() for this new event? |
|
Hello @esmail9900 and thank you for your PR. Your PR gave me some strong flashbacks from when I attempted to add this event and lost motivation. Please view the comments on this PR #10 and check if your code complies with all that have been said in this PR. Thank you. |
There was a problem hiding this comment.
some stuff needs to be adressed.
I think the this event do not need to be cancelable right away, this can be added later with another PR as you will surely encounter some tricky problems to overcome to make it work properly.
Note: What happens if you delete the team ?
(Expectected behaviour would be that this event gets called for every players in the team and before onElementDestroy gets called so that it is already at the right place if you or someone else decides to make your event cancelable)
Added cancelEvent() Before team getting destroyed, event will trigger for all players in the team
oldTeam changed to team element instead of nil when team getting destroyed
Co-authored-by: Citizen01 <[email protected]>
|
mb, i just confused, im new to github :D |
Moving CLuaArguments creation outside the loop and calling 'DeleteArguments()' within each iteration.
|
There are enough passed code reviews, thanks for your contribution @esmail9900 |
implemented the onPlayerTeamChange event for the server-side. this event includes two arguments: oldTeam and newTeam. if the player doesn't have an old team, oldTeam will be false.