Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update acl.xml - add runcode loadstring permission #3393

Closed

Conversation

Fernando-A-Rocha
Copy link
Contributor

@Fernando-A-Rocha Fernando-A-Rocha commented May 17, 2024

Default MTA Resource runcode requires function.loadstring access.

With default acl.xml, it kept printing a warning when you start the MTA server.

It was missing, gives warning on MTA server with default resources startup
Server/mods/deathmatch/acl.xml Outdated Show resolved Hide resolved
Server/mods/deathmatch/acl.xml Outdated Show resolved Hide resolved
@jlillis
Copy link

jlillis commented May 25, 2024

I don't think we should give runcode any rights by default. It would be better to make admins explicitly give it loadstring access using an aclrequest.

@Fernando-A-Rocha
Copy link
Contributor Author

I don't think we should give runcode any rights by default. It would be better to make admins explicitly give it loadstring access using an aclrequest.

Sure, it should only be used by server developers that know what they're doing with the code ran...

@Fernando-A-Rocha Fernando-A-Rocha requested a review from Nico8340 May 31, 2024 09:41
@Fernando-A-Rocha
Copy link
Contributor Author

Naming changes were made in case you guys want to implement this

Copy link
Contributor

@Nico8340 Nico8340 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Naming is suitable for me, it fits into our scheme, but the team has to make the decision in this matter for security reasons.

@botder
Copy link
Member

botder commented Jun 3, 2024

Personally, I would not add this to the default acl.xml

@Dutchman101
Copy link
Member

Thanks for the suggestion, but no

@Fernando-A-Rocha Fernando-A-Rocha deleted the acl-fix-runcode branch June 22, 2024 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants