Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix pickup serverside Collision #3420

Merged
merged 3 commits into from
Jun 5, 2024
Merged

fix pickup serverside Collision #3420

merged 3 commits into from
Jun 5, 2024

Conversation

Proxy-99
Copy link
Contributor

@Proxy-99 Proxy-99 commented May 31, 2024 •
edited by botder
Loading

Fixes #3417

Nico8340
Nico8340 approved these changes Jun 1, 2024
View reviewed changes
Copy link
Contributor

@Nico8340 Nico8340 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 🎉

@botder
Copy link
Member

botder commented Jun 3, 2024

Isn't this going to break scripts?

@Proxy-99
Copy link
Contributor Author

Proxy-99 commented Jun 3, 2024 •
edited
Loading

Isn't this going to break scripts?

I agree it will change the size of trigger on the server side pickups which can affect some scripts.

tho I do not like the function createPickup() I think you should be able to specify the collision size and this will help us avoid breaking things

@botder botder merged commit 49d9751 into multitheftauto:master Jun 5, 2024
6 checks passed
@botder botder added the enhancement New feature or request label Jun 5, 2024
@botder botder added this to the 1.6.1 milestone Jun 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tederis tederis tederis approved these changes

@Fernando-A-Rocha Fernando-A-Rocha Fernando-A-Rocha approved these changes

@botder botder botder approved these changes

@Nico8340 Nico8340 Nico8340 approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
1.6.1
Development

Successfully merging this pull request may close these issues.

Collision Differences Between onClientPlayerPickupHit and onPlayerPickupHit
5 participants
@Proxy-99 @botder @tederis @Fernando-A-Rocha @Nico8340