Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add removeGameWorld and restoreGameWorld #3627

Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open

Add removeGameWorld and restoreGameWorld #3627

wants to merge 11 commits into from

Conversation

TheNormalnij
Copy link
Member

Fixes #3607
removeAllGameBuildings cleans only buildings pool and leaves rare dynamic elements in the game world.
removeGameWorld fixes that issue by cleaning the dummies pool too.

-- Removes all buildings and dummies from game world and frees both pools
nil removeGameWorld()

-- Restores all buildings and dummies
nil restoreGameWorld()

removeAllGameBuildings and restoreAllGameBuildings will be deprecated and removed in future releases

@TheNormalnij TheNormalnij added enhancement New feature or request bugfix Solution to a bug of any kind labels Aug 2, 2024
@TheNormalnij TheNormalnij added this to the 1.6.1 milestone Aug 2, 2024
TracerDS
TracerDS suggested changes Aug 2, 2024
View reviewed changes
Client/game_sa/CDummyPoolSA.cpp Outdated Show resolved Hide resolved
Client/game_sa/CDummyPoolSA.cpp Show resolved Hide resolved
Client/game_sa/CDummyPoolSA.cpp Outdated Show resolved Hide resolved
Client/game_sa/CDummyPoolSA.cpp Show resolved Hide resolved
Client/game_sa/CDummyPoolSA.cpp Outdated Show resolved Hide resolved
Client/game_sa/CDummyPoolSA.cpp Outdated Show resolved Hide resolved
Client/game_sa/CDummyPoolSA.cpp Outdated Show resolved Hide resolved
Client/game_sa/CDummyPoolSA.cpp Outdated Show resolved Hide resolved
Client/game_sa/CGameSA.cpp Show resolved Hide resolved
@TheNormalnij TheNormalnij marked this pull request as ready for review August 4, 2024 17:07
TracerDS
TracerDS suggested changes Aug 21, 2024
View reviewed changes
Client/game_sa/CDummyPoolSA.cpp Outdated Show resolved Hide resolved
Client/game_sa/CDummyPoolSA.cpp Show resolved Hide resolved
Client/game_sa/CPoolSAInterface.h Show resolved Hide resolved
Client/game_sa/CPoolSAInterface.h Show resolved Hide resolved
@Fernando-A-Rocha
Copy link
Contributor

@TheNormalnij will u please update the wiki? Let me know if u need advice

@TheNormalnij
Copy link
Member Author

@TheNormalnij will u please update the wiki? Let me know if u need advice

Yep

Fernando-A-Rocha

This comment was marked as outdated.

Sign in to view

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TracerDS TracerDS TracerDS requested changes

@Dutchman101 Dutchman101 Dutchman101 left review comments

@Fernando-A-Rocha Fernando-A-Rocha Fernando-A-Rocha approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
bugfix Solution to a bug of any kind enhancement New feature or request
Projects
None yet
Milestone
1.6.1
Development

Successfully merging this pull request may close these issues.

removeAllGameBuildings doesn't remove the whole map
4 participants
@TheNormalnij @Fernando-A-Rocha @Dutchman101 @TracerDS