Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add async dbConnect #3632

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Add async dbConnect #3632

wants to merge 9 commits into from

Conversation

TracerDS
Copy link
Contributor

@TracerDS TracerDS commented Aug 5, 2024

Resolves #410

@TracerDS TracerDS marked this pull request as ready for review August 5, 2024 10:08
@tederis tederis added the enhancement New feature or request label Aug 10, 2024
tederis
tederis requested changes Aug 10, 2024
View reviewed changes
Shared/sdk/SharedUtil.Misc.h Outdated Show resolved Hide resolved
Shared/sdk/SharedUtil.Misc.h Show resolved Hide resolved
Shared/sdk/SharedUtil.Misc.h Show resolved Hide resolved
Client/core/CVersionUpdater.Util.hpp Show resolved Hide resolved
Server/mods/deathmatch/logic/luadefs/CLuaDatabaseDefs.cpp Show resolved Hide resolved
Shared/sdk/SharedUtil.Misc.hpp
std::string result;
if (Get(inCmd, result))
{
value = atoi(result.c_str());
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, use C++ alternatives.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would require either defining a function for converting strings to numbers or surrounding it with try-catch.
Function would be better there, no?

Shared/sdk/SharedUtil.Misc.h Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tederis tederis tederis requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Get dbConnect handle in other ways
2 participants
@TracerDS @tederis