Fixed isPlayerHudComponentVisible not working with showhud #3634
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheNormalnij
reviewed
Aug 8, 2024
TheNormalnij
reviewed
Aug 8, 2024
| @@ -43,6 +43,9 @@ void CHudSA::Disable(bool bDisabled) | |||
| else | |||
| MemPut<BYTE>(FUNC_Draw, 0x80); | |||
|
|
|||
| for (const auto& component : m_HudComponentMap) | |||
| SetComponentVisible(component.first, !IsComponentVisible(component.first)); | |||
There was a problem hiding this comment.
It looks like isPlayerHudComponentVisible will return true for a hidden component after showhud
There was a problem hiding this comment.
Hmm, do you think a copy of the components map would be good here?
To save status of each component and then restore it on the next call
|
Check conversation in #547. @qaisjp suggested bool isPlayerHudComponentVisible(string component, bool checkEnabled=true)I'd like to keep -- returns true by default and false when showhud command is used
bool isHudEnabled()Both variants are valid. |
|
Any update? |
|
Im not interested in advancing this PR further anymore. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #547